Closed
Bug 1181038
Opened 9 years ago
Closed 9 years ago
"Harness status: OK" + failing test when running "performance-timeline.https.html" test
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox42 affected, firefox43 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: noemi, Assigned: nsm)
References
Details
Attachments
(1 file)
Checked with 7/6 master build Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/performance-timeline.https.html| Result: * Harness status: OK * Found 1 tests * 1 Fail: ** Test Performance Timeline API in Service Worker *** assert_unreached: unregister and register should not fail: The expression cannot be converted to return the specified type. Reached unreachable code unreached_rejection/<@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:42:7 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1387:1 Promise*service_worker_unregister_and_register@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:8:10 service_worker_test/<@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:146:14 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 promise_test@https://web-platform.test:8443/resources/testharness.js:520:25 service_worker_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:145:1 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/performance-timeline.https.html:7:1 * Traces: https://pastebin.mozilla.org/8838629
Reporter | ||
Updated•9 years ago
|
Summary: "Harness status: OK" + failing test when running wpt "performance-timeline.https.html" test → "Harness status: OK" + failing test when running "performance-timeline.https.html" test
Reporter | ||
Updated•9 years ago
|
Component: DOM: Service Workers → web-platform-tests
Product: Core → Testing
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1181038 - Add performance timing worker. r?jgraham This adds the file and fixes the path to make the test run. We do not support performance timing on workers yet. I filed Bug 1203749 for that. Update web-platform-tests expected data
Attachment #8659581 -
Flags: review?(james)
Reporter | ||
Comment 2•9 years ago
|
||
Patch provided by Nikhil so assigning this to him. Please feel free to change it as needed. Thanks!
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
This still needs reviewing after wpt update.
Flags: needinfo?(james)
Comment 4•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham https://reviewboard.mozilla.org/r/18969/#review17259 ::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/performance-timeline-worker.js:28 (Diff revision 1) > + return fetch('../../resources/dummy.txt') Should this be changed to a path that exists? ::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/performance-timeline-worker.js:37 (Diff revision 1) > + return new Promise(function(resolve, reject) { Sounds like this setTimeout should be removed. ::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/performance-timeline-worker.js:42 (Diff revision 1) > + var expectedResources = ['/resources/testharness.js', '/resources/dummy.txt']; Again, dummy.txt
Attachment #8659581 -
Flags: review?(james)
Updated•9 years ago
|
Flags: needinfo?(james)
Assignee | ||
Updated•9 years ago
|
Attachment #8659581 -
Flags: review?(james)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham Bug 1181038 - Add performance timing worker. r?jgraham This adds the file and fixes the path to make the test run. We do not support performance timing on workers yet. I filed Bug 1203749 for that. Update web-platform-tests expected data
Assignee | ||
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/18969/#review17313 Note, you've to check "Ship It" to r+
Assignee | ||
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/18969/#review17259 > Should this be changed to a path that exists? there is no dummy.txt anywhere, I believe the intent is only to record a load attempt, which we do not support on SWs right now.
Comment 8•9 years ago
|
||
https://reviewboard.mozilla.org/r/18969/#review17259 > there is no dummy.txt anywhere, I believe the intent is only to record a load attempt, which we do not support on SWs right now. Isn't it https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/http/tests/resources/dummy.txt&q=dummy.txt&sq=package:chromium&l=1 ?
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(nsm.nikhil)
Updated•9 years ago
|
Attachment #8659581 -
Flags: review?(james)
Comment 9•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham https://reviewboard.mozilla.org/r/18969/#review17395 ::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/performance-timeline-worker.js:33 (Diff revision 2) > + // TODO(hiroshige): The resource timing entry for dummy.txt is added Remove this comment. Still needs a dummy.txt file to be added, I think.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Updated•9 years ago
|
Attachment #8659581 -
Flags: review?(james)
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham Bug 1181038 - Add performance timing worker. r?jgraham This adds the file and fixes the path to make the test run. We do not support performance timing on workers yet. I filed Bug 1203749 for that. Update web-platform-tests expected data
Comment 11•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham https://reviewboard.mozilla.org/r/18969/#review17427
Attachment #8659581 -
Flags: review?(james) → review+
Assignee | ||
Comment 12•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0815f7aaba92
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8659581 [details] MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham Bug 1181038 - Add performance timing worker. r=jgraham This adds the file and fixes the path to make the test run. We do not support performance timing on workers yet. I filed Bug 1203749 for that. Update web-platform-tests expected data
Attachment #8659581 -
Attachment description: MozReview Request: Bug 1181038 - Add performance timing worker. r?jgraham → MozReview Request: Bug 1181038 - Add performance timing worker. r=jgraham
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c9d2dab60f3
Keywords: checkin-needed
Backed out for w(4) bustage https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb3b6b4c08c
https://treeherder.mozilla.org/logviewer.html#?job_id=14277612&repo=mozilla-inbound
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Comment 17•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a41937bf6a2b1cfdf984999894e9d2f51c2dbc8 Bug 1181038 - Add performance timing worker. r=jgraham
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(nsm.nikhil)
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a41937bf6a2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Reporter | ||
Comment 19•9 years ago
|
||
Hi, just checked in m-c (6227054b7811 revision) and one of the tests is failing (ni to Nikhil), please see below the details: Summary Harness status: OK Found 3 tests 2 Pass 1 Fail Details Result Test Name Pass Test Performance Timeline API in Service Worker Pass User Timing Fail Resource Timing assert_equals: expected 2 but got 0 *Message: @https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/performance-timeline-worker.js:37:1 promise callback*@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/performance-timeline-worker.js:31:12 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1380:20 promise callback*promise_test@https://web-platform.test:8443/resources/testharness.js:526:31 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/performance-timeline-worker.js:30:1
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Comment 20•9 years ago
|
||
This is a known issue that we do not need to fix to ship. Bug 1203747.
Flags: needinfo?(nsm.nikhil)
You need to log in
before you can comment on or make changes to this bug.
Description
•