Closed Bug 1181042 Opened 9 years ago Closed 9 years ago

[TSF] TSF should be disabled in Mozilla 40 since some important bugs are fixed in Mozilla 41

Categories

(Core :: Widget: Win32, defect)

40 Branch
x86
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox39 --- unaffected
firefox40 + fixed
firefox41 --- unaffected
firefox42 --- unaffected

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

[Tracking Requested - why for this release]:

We agreed that we'll enable TSF in release builds at Mozilla 40. However, we fixed some important bugs in Mozilla 41:
https://bugzilla.mozilla.org/buglist.cgi?keywords=inputmethod%2C%20&f1=OP&keywords_type=allwords&list_id=12374315&f0=OP&resolution=FIXED&f4=CP&query_format=advanced&j1=OR&f3=CP&product=Core&product=Firefox&product=Other%20Applications&product=SeaMonkey&product=Thunderbird&product=Toolkit&target_milestone=mozilla41&target_milestone=mozilla41&target_milestone=mozilla41

Especially, bug 1162818 causes crash in TSF (or TIP?). So, we should put off to enable TSF until Mozilla 41.

I think that the best time to back it out around 7/24 since TSF should be tested by Beta users but IMM mode should be tested too.
And also, bug 1172466 could cause some odd behavior.
I don't know what TSF is but I'll take your word that we should disable this. 

Masayuki - Can you please get a fix ready for either beta3 (gtb Thursday) or beta4 (gtb Monday)?
Flags: needinfo?(masayuki)
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #2)
> I don't know what TSF is but I'll take your word that we should disable this. 

TSF is new IME API set on Windows. This improves a lot of features including relationship with a11y tools.

> Masayuki - Can you please get a fix ready for either beta3 (gtb Thursday) or
> beta4 (gtb Monday)?

It's possible, but I hope that we should give feedback as far as long time since it's important larger number testers to test the TSF mode with various IMEs. If we wouldn't get some important report in this chance, but we'd get them in next cycle, we need to put off again. As I mentioned above, this is important. Especially, we should ship this feature with vertical writing mode support. So, this must be the last change.

Even with this situation, do you believe that we should disable TSF on next Monday?
Flags: needinfo?(masayuki) → needinfo?(lmandel)
> we should give feedback

I meant, we should get feedback...
I didn't realize that you are looking for feedback on Beta. If that's the case, we should disable this before beta5 (after beta4 ships) as that is our cutoff for this type of testing in early beta. This means we'll want to disable TSF on Tue or Wed next week.
Flags: needinfo?(lmandel)
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #5)
> I didn't realize that you are looking for feedback on Beta. If that's the
> case, we should disable this before beta5 (after beta4 ships) as that is our
> cutoff for this type of testing in early beta. This means we'll want to
> disable TSF on Tue or Wed next week.

Okay, then, we should fix this with that schedule.
Let's disable TSF mode only on 40. 41 should be the first release of TSF mode.
Attachment #8632673 - Flags: review?(m_kato)
Attachment #8632673 - Flags: review?(jmathies)
Comment on attachment 8632673 [details] [diff] [review]
Disable TSF in default settings (only on 40)

agreed
Attachment #8632673 - Flags: review?(m_kato) → review+
Attachment #8632673 - Flags: review?(jmathies) → review+
Comment on attachment 8632673 [details] [diff] [review]
Disable TSF in default settings (only on 40)

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: 40 still has some critical bugs of TSF. We should wait 41 for enabling TSF mode.
[Describe test coverage new/current, TreeHerder]: Rolling back to IMM mode which is the previous behavior.
[Risks and why]: Not risky because IMM mode is enough stable, ~39 use IMM mode.
[String/UUID change made/needed]: Nothing.
Attachment #8632673 - Flags: approval-mozilla-beta?
Comment on attachment 8632673 [details] [diff] [review]
Disable TSF in default settings (only on 40)

Disable TSF. Beta+
Attachment #8632673 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tracking 40 to ensure TSF is disabled.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.