Closed Bug 1181136 Opened 9 years ago Closed 9 years ago

[Messages] When sending a MMS in airplane mode, the display stays in "sending" state after the error

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Whiteboard: [sms-papercuts][sms-sprint-FxOS-S3])

Attachments

(1 file)

STR:
1. set airplane mode.
2. enter an existing thread inside the Messages application.
3. Try to send a MMS (with an attachment, or a subject).
4. Dismiss the error.

Expected:
* The message should be error-ed.

Actual:
* The message is marked "sending".
* When going back to the thread list and loading the thread again, then it's properly error-ed.

First step is to see whether this comes from Gecko or Gaia.
I think this is a regression of bug 1091441.
Blocks: 1091441
Comment on attachment 8630701 [details] [review]
[gaia] julienw:1181136-fix-race-sending-error-mms > mozilla-b2g:master

Hey Steve,

what do you think of this patch?
Attachment #8630701 - Flags: review?(schung)
Assignee: nobody → felash
Whiteboard: [sms-papercuts] → [sms-papercuts][sms-sprint-FxOS-S3]
Haven't tried this on real device but code looks good, will verify it ASAP.
This can wait one more night !
Comment on attachment 8630701 [details] [review]
[gaia] julienw:1181136-fix-race-sending-error-mms > mozilla-b2g:master

Looks good. I only left one thought but it's not important, so r=me. Thanks!
Attachment #8630701 - Flags: review?(schung) → review+
Rebased, waited for a green try, landed:
master: 302a448729ff2b336581cf94b66327ea836294c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: