1181155 - Create a common RootLists structure to share the root list fields between PerThreadData and ContextFriendFields

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: split_out_root_list_structures-v0.diff

This seems slightly cleaner to me.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4db69179ff3e

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8630476 [details] [diff] [review]
split_out_root_list_structures-v0.diff

Review of attachment 8630476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: js/src/jspubtd.h
@@ +355,5 @@
>  template <> struct RootKind<jsid> : SpecificRootKind<jsid, THING_ROOT_ID> {};
>  template <> struct RootKind<JS::Value> : SpecificRootKind<JS::Value, THING_ROOT_VALUE> {};
>  
> +// Abstracts JS rooting mechanisms so that it can be mixed into and rooting
> +// mechanisms used with any of PerThreadData, JSRuntime, and JSContext

I'm not sure about the use of "mixed into" here.  It sounds like you're talking about mixins, but I don't think that's the case.

Also the comment needs full stop at the end.

@@ +363,5 @@
> +    JS::Rooted<void*>* stackRoots_[THING_ROOT_LIMIT];
> +    template <typename T> friend class JS::Rooted;
> +
> +    // Stack GC roots for stack-allocated AutoFooRooter classes.
> +    JS::AutoGCRooter*  autoGCRooters_;

Nit: Remove extra space between type and field name.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff297c4e78a1

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff297c4e78a1