[e10s] View Source in window cannot print preview

RESOLVED FIXED in Firefox 42

Status

()

Toolkit
View Source
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

({regression})

unspecified
mozilla42
regression
Points:
---

Firefox Tracking Flags

(e10s+, firefox40 unaffected, firefox41 affected, firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

STR:

1) Set view_source.tab to false
2) Visit a website, and ensure that there is a "- e10s" suffix in the tab title to ensure that it's running out-of-process
3) View the source of the page (Ctrl/Cmd-U)
4) File > Print Preview

ER:

Should display the print preview of the source

AR:

Shows the print preview progress dialog which never closes on its own. The print preview is never shown.

I don't think I'm going to mark this tracking or try to uplift this, since viewing source in a window is no longer the default. But we should fix this.
This is simply a matter of making sure that the print preview browser that the view source window uses is remote if the view source browser is remote. In the future, once we support dom.ipc.processCount > 1, we'll also need to ensure that the newly created browser is in the same process, but for now, just making sure its remoteness matches the view source browser should work.
Created attachment 8630485 [details]
MozReview Request: Bug 1181160 - Make print preview work in view source window when viewing source from a remote browser. r?jryans

Bug 1181160 - Make print preview work in view source window when viewing source from a remote browser. r?jryans

We weren't making the print preview browser remote for the view source
window if the view source browser was remote, causing us to fail to
show the preview.
Attachment #8630485 - Flags: review?(jryans)
tracking-e10s: ? → +
Is it meant to work on Mac?  There is no File -> Print Preview there, but "Open PDF in Preview" from the Print dialog has no effect at the moment.  Also, I see the message: 

JavaScript error: chrome://global/content/browser-content.js, line 509: TypeError: printSettings is null
Flags: needinfo?(mconley)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Is it meant to work on Mac?  There is no File -> Print Preview there, but
> "Open PDF in Preview" from the Print dialog has no effect at the moment. 
> Also, I see the message: 
> 
> JavaScript error: chrome://global/content/browser-content.js, line 509:
> TypeError: printSettings is null

I'm pretty sure we don't offer print preview on OS X deliberately, as that's platform convention (I believe the idea is that the print dialog is supposed to show a preview, and the user can open a PDF in Preview.app from that dialog to preview as well).

So to test this, Linux or Windows will be needed.
Flags: needinfo?(mconley)
Assignee: nobody → mconley
Comment on attachment 8630485 [details]
MozReview Request: Bug 1181160 - Make print preview work in view source window when viewing source from a remote browser. r?jryans

https://reviewboard.mozilla.org/r/12751/#review11463

Great, worked well for me.  Tested on Linux.
Attachment #8630485 - Flags: review?(jryans) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/425bb12cd26f9acd33a2f45adf3102da63df3544
changeset:  425bb12cd26f9acd33a2f45adf3102da63df3544
user:       Mike Conley <mconley@mozilla.com>
date:       Fri Jul 03 18:20:07 2015 -0400
description:
Bug 1181160 - Make print preview work in view source window when viewing source from a remote browser. r=jryans

We weren't making the print preview browser remote for the view source
window if the view source browser was remote, causing us to fail to
show the preview.
https://hg.mozilla.org/mozilla-central/rev/425bb12cd26f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.