Stagefright: CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1 in MPEG4Extractor.cpp

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: Playback
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: tsmith, Assigned: gerald)

Tracking

(Blocks: 1 bug, {crash, testcase})

unspecified
mozilla45
crash, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

(Whiteboard: checkin after 1181719, 1181223, 1181220, 1181215)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8630560 [details]
test_case.mp4

A/MPEG4Extractor(34214): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:2643 CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1
(Reporter)

Updated

3 years ago
Blocks: 872136
(Reporter)

Updated

2 years ago
Summary: CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1 in MPEG4Extractor.cpp → Stagefright: CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1 in MPEG4Extractor.cpp
Component: Audio/Video → Audio/Video: Playback
Gerald, here's another Stagefright bug.
Assignee: nobody → gsquelart
Priority: -- → P1
(Assignee)

Comment 2

2 years ago
Created attachment 8683925 [details] [diff] [review]
1181213-gtest.patch

Added gtest case.

Note: This bug is effectively fixed by bug 1181215, so only this test case is
provided here to prove the successful resolution of this bug.
Attachment #8683925 - Flags: review?(giles)
(Assignee)

Updated

2 years ago
Depends on: 1181215
Comment on attachment 8683925 [details] [diff] [review]
1181213-gtest.patch

Review of attachment 8683925 [details] [diff] [review]:
-----------------------------------------------------------------

Probably good to meantion mp4 in commit message.

"Bug 1181213 - Added mp4 gtest case - r=rillian"
Attachment #8683925 - Flags: review?(giles) → review+
(Assignee)

Comment 4

2 years ago
Created attachment 8684003 [details] [diff] [review]
1181213-gtest.patch

Clarified check-in comment, no actual changes; carrying r+.
Attachment #8683925 - Attachment is obsolete: true
Attachment #8684003 - Flags: review+
(Assignee)

Comment 5

2 years ago
Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695
Keywords: checkin-needed
Whiteboard: checkin after 1181719, 1181223, 1181220, 1181215

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f4513bf2d03
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f4513bf2d03
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f4513bf2d03
You need to log in before you can comment on or make changes to this bug.