1181215 - Stagefright: CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed in MPEG4Extractor.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.mp4

A/MPEG4Extractor(34284): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:2649 CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed.

Comment 1

[Jean-Yves Avenard [:jya]]

What is the aim of your mp4 tests?

What do you expect the code to do?

Comment 2

[Tyson Smith [:tsmith]]

Hi Jean-Yves,

I am part of the platform fuzzing team. The aim of our team is to fuzz different parts of the code base to find stability and security issues.

In the context of media playback a 'pass' would be the browser not crashing/asserting when given a fuzzed file for playback.

If you would like more information about fuzzing please feel free to email me or ping me on IRC (:tsmith)

Comment 3

[Chris Peterson [:cpeterson]]

Gerald, here's another Stagefright bug.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181215-gtest.patch

Part 1: Added gtest case.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181215-verify-tracks-better.patch

Part 2: Better track verification.

Copied some tests from MPEG4Source constructor to MPEG4Extractor::verifyTrack
so that we don't get late surprises, in particular a missing track ID.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The patch in this bug includes a fix for bug 1181213 (unexpected configurationVersion).

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8683614 [details] [diff] [review]
1181215-gtest.patch

Review of attachment 8683614 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing all these tests.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181215-gtest.patch

Clarified check-in comment, no actual changes; carrying r+.

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8db80facd1a
https://hg.mozilla.org/integration/mozilla-inbound/rev/e61b1ed57f87

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8db80facd1a
https://hg.mozilla.org/mozilla-central/rev/e61b1ed57f87

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8db80facd1a
https://hg.mozilla.org/mozilla-central/rev/e61b1ed57f87