Closed Bug 1181215 Opened 6 years ago Closed 6 years ago

Stagefright: CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed in MPEG4Extractor.cpp

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: tsmith, Assigned: gerald)

References

Details

(Keywords: crash, testcase, Whiteboard: [fuzzblocker:stagefright] checkin after 1181719, 1181223, 1181220 but before 1181213)

Attachments

(3 files, 1 obsolete file)

Attached video test_case.mp4
A/MPEG4Extractor(34284): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:2649 CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed.
What is the aim of your mp4 tests?

What do you expect the code to do?
Flags: needinfo?(twsmith)
Hi Jean-Yves,

I am part of the platform fuzzing team. The aim of our team is to fuzz different parts of the code base to find stability and security issues.

In the context of media playback a 'pass' would be the browser not crashing/asserting when given a fuzzed file for playback.

If you would like more information about fuzzing please feel free to email me or ping me on IRC (:tsmith)
Flags: needinfo?(twsmith)
Whiteboard: [fuzzblocker:stagefright]
Summary: CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed in MPEG4Extractor.cpp → Stagefright: CHECK(format->findInt32(kKeyTrackID, &mTrackId)) failed in MPEG4Extractor.cpp
Component: Audio/Video → Audio/Video: Playback
Gerald, here's another Stagefright bug.
Assignee: nobody → gsquelart
Priority: -- → P1
Attached patch 1181215-gtest.patch (obsolete) — Splinter Review
Part 1: Added gtest case.
Attachment #8683614 - Flags: review?(giles)
Part 2: Better track verification.

Copied some tests from MPEG4Source constructor to MPEG4Extractor::verifyTrack
so that we don't get late surprises, in particular a missing track ID.
Attachment #8683615 - Flags: review?(giles)
The patch in this bug includes a fix for bug 1181213 (unexpected configurationVersion).
Blocks: 1181213
Comment on attachment 8683614 [details] [diff] [review]
1181215-gtest.patch

Review of attachment 8683614 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing all these tests.
Attachment #8683614 - Flags: review?(giles) → review+
Attachment #8683615 - Flags: review?(giles) → review+
Clarified check-in comment, no actual changes; carrying r+.
Attachment #8683614 - Attachment is obsolete: true
Attachment #8684002 - Flags: review+
Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695
Keywords: checkin-needed
Whiteboard: [fuzzblocker:stagefright] → [fuzzblocker:stagefright] checkin after 1181719, 1181223, 1181220 but before 1181213
https://hg.mozilla.org/mozilla-central/rev/f8db80facd1a
https://hg.mozilla.org/mozilla-central/rev/e61b1ed57f87
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
See Also: → 1233688
You need to log in before you can comment on or make changes to this bug.