1181220 - Stagefright: CHECK(!"should not be here.") failed in MPEG4Extractor.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.mp4

A/MPEG4Extractor(34357): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:354 CHECK(!"should not be here.") failed.

Comment 1

[Chris Peterson [:cpeterson]]

Gerald, here's another Stagefright bug.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181220-gtest.patch

Part 1: Added gtest case.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181220-check-MIME-types.patch

Part 2: Check if MIME types are valid.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8683546 [details] [diff] [review]
1181220-check-MIME-types.patch

Review of attachment 8683546 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +1026,4 @@
>              }
> +            const char* mime = FourCC2MIME(original_fourcc);
> +            if (!mime) {
> +                return ERROR_MALFORMED;

This could be just an unrecognized type, not a malformed one. It might be nice to distinguish?

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181220-gtest.patch

Clarified check-in comment, no actual changes; carrying r+.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181220-check-MIME-types.patch

As per review suggestion, changed error code constant to ERROR_UNSUPPORTED when stumbling upon an unknown MIME type. Carrying r+.

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5555f3b9712
https://hg.mozilla.org/integration/mozilla-inbound/rev/7964a5a4b0bd

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5555f3b9712
https://hg.mozilla.org/mozilla-central/rev/7964a5a4b0bd

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5555f3b9712
https://hg.mozilla.org/mozilla-central/rev/7964a5a4b0bd