1181239 - Enable eslint "use strict" function rule for content code

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Our chrome code has "use strict" enabled already. We should enable the rule for our content code as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Enable eslint 'use strict' function rule for Loop's content code.

Simple additions. I had to re-indent some blocks for the ui/ files, but this seemed better than adding "use strict" for every individual function.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8630589 [details] [diff] [review]
Enable eslint 'use strict' function rule for Loop's content code.

Review of attachment 8630589 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose on .eslintrc, rs=dmose on all the rest.  Thanks for the patch!

::: browser/components/loop/.eslintrc
@@ +60,5 @@
>      "no-use-before-define": 0,    // TODO: Remove (use default)
>      "object-curly-spacing": 0,    // [2, "always"],
>      "quotes": [2, "double", "avoid-escape"],
>      "spaced-comment": [2, "always"],
> +    "strict": [2, "function"],                  // [2, "function"],

You can probably remove the comment here, or maybe replace it with a link to http://eslint.org/docs/rules/strict#function-mode

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fe15e80f18f2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe15e80f18f2