118126 - HP & AIX optimized builds core'ing on startup

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jim Dunn]

My 0.9.7 Optimized HP-UX & AIX builds were core'ing on startup
and upon further investigation it turns out that they used to
remove the -O option when building xpcom/reflect/xptcall/src/md/unix/*.cpp.
However, with the new optimize method that was introduced via 
http://bugzilla.mozilla.org/show_bug.cgi?id=110215, this method of
overriding OS_CXXFLAGS no longer works.

Comment 1

[Jim Dunn]

*** Bug 118129 has been marked as a duplicate of this bug. ***

Comment 2

[Jim Dunn]

Attachment: force the building without -O

This will fix AIX & HP-UX, however there are other references to OS_CXXFLAGS
in this makefile and I am wondering if these should be modified as well.

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 63495 [details] [diff] [review]
force the building without -O

Argh! Sorry about that.  I think that the proper thing to do in this case would
be to change all of the OS_CXXFLAGS to CXXFLAGS.  There's no reason that I can
see to use OS_CXXFLAGS and only overriding MOZ_OPTIMIZE_FLAGS will miss if
anyone decides to set MODULE_OPTIMIZE_FLAGS.

Comment 4

[Jim Dunn]

Attachment: New patch based on CLS's suggestion (modify CXXFLAGS)

CLS mentioned that we should modify CXXFLAGS and not use OS_CXXFLAGS.

Comment 5

[Jim Dunn]

I know my AIX & HP-UX changes work... but I can't
verify if solaris/intel or irix work.

I can either check in ALL of these changes or I can
just checkin mine... cls what do u think?
others?

cls can you give me a r= for one way or another?

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 63575 [details] [diff] [review]
New patch based on CLS's suggestion (modify CXXFLAGS)

Checking all of the changes in should be fine.	There's no place in the build
where we use just OS_CXXFLAGS to build, it's always CXXFLAGS or
COMPILE_CXXFLAGS.

r=cls

Comment 7

[Jim Dunn]

fix checked in