Closed Bug 1181292 Opened 5 years ago Closed 5 years ago

Use generic Traceable rooting for JSPropertyDescriptor

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Instead of having a special category for JSPropertyDescriptor, we should be able to use the generic rooting infrastructure now.

Eric, is adding a vtable to JSPropertyDescriptor a hilariously bad idea? From what I recall we don't actually store them anywhere persistent, so I think this should be okay. Tests pass locally at least.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=215fbf8384fe
Attachment #8630666 - Flags: review?(efaustbmo)
Actually, we don't even need the vtable.
Attachment #8630666 - Attachment is obsolete: true
Attachment #8630666 - Flags: review?(efaustbmo)
Attachment #8631279 - Flags: review?(efaustbmo)
Comment on attachment 8631279 [details] [diff] [review]
convert_jspropertydescriptor_to_static_traceable-v1.diff

Review of attachment 8631279 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. This is super cool.
Attachment #8631279 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/8d2d0a61f5df
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.