Closed
Bug 1181292
Opened 9 years ago
Closed 9 years ago
Use generic Traceable rooting for JSPropertyDescriptor
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
4.28 KB,
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
Instead of having a special category for JSPropertyDescriptor, we should be able to use the generic rooting infrastructure now. Eric, is adding a vtable to JSPropertyDescriptor a hilariously bad idea? From what I recall we don't actually store them anywhere persistent, so I think this should be okay. Tests pass locally at least. https://treeherder.mozilla.org/#/jobs?repo=try&revision=215fbf8384fe
Attachment #8630666 -
Flags: review?(efaustbmo)
|
Assignee | |
Comment 1•9 years ago
|
||
Actually, we don't even need the vtable.
Attachment #8630666 -
Attachment is obsolete: true
Attachment #8630666 -
Flags: review?(efaustbmo)
Attachment #8631279 -
Flags: review?(efaustbmo)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8631279 [details] [diff] [review] convert_jspropertydescriptor_to_static_traceable-v1.diff Review of attachment 8631279 [details] [diff] [review]: ----------------------------------------------------------------- Nice. This is super cool.
Attachment #8631279 -
Flags: review?(efaustbmo) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8d2d0a61f5df
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•