Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8630700 [details] [diff] [review]
Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses
(Assignee)

Updated

3 years ago
Assignee: nobody → michael
Blocks: 602122
(Assignee)

Updated

3 years ago
Attachment #8630700 - Flags: review?(bugs)

Comment 2

3 years ago
Comment on attachment 8630700 [details] [diff] [review]
Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses

baku, could you review this? You're more familiar with Promise code.
Attachment #8630700 - Flags: review?(bugs) → review?(amarchesini)
Comment on attachment 8630700 [details] [diff] [review]
Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses

Review of attachment 8630700 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +1596,5 @@
>  
>    virtual ~KeepAliveHandler()
>    {}
>  
> +  NS_DECL_ISUPPORTS

not public?
Attachment #8630700 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8631640 [details] [diff] [review]
Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses

Technically NS_DECL_ISUPPORTS starts and ends with `public:`, but I agree it is more clear to put the macro within the `public:` block.
Attachment #8630700 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f4f0cd48a2a8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.