1181342 - Add clang 3.6 builds for TSan

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I got as far as figuring out I don't have the appropriate permissions to upload to tooltool and wondering whether I should be able to run build-clang.py locally.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

rail, can you help me figure out how to do this? Thanks!

Comment 2

[Rail Aliiev [:rail]]

Sure!

We have a wiki page on how to build clang here: https://wiki.mozilla.org/ReleaseEngineering/How_To/Clang_update

Tooltool is described here: https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool

Let me know if the docs are missing something.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail

Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I got a working build out of https://treeherder.mozilla.org/#/jobs?repo=try&revision=0266fc9845f6

Comment 5

[Chris Manchester (limited bugmail, email directly)]

(In reply to Rail Aliiev [:rail] from comment #2)
> Sure!
> 
> We have a wiki page on how to build clang here:
> https://wiki.mozilla.org/ReleaseEngineering/How_To/Clang_update
> 
> Tooltool is described here:
> https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool
> 
> Let me know if the docs are missing something.

The only hiccup was the VM was set up with gcc 4.7.2, but the build-clang script mentioned gcc 4.7.3.

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8632178 [details]
MozReview Request: Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail

https://reviewboard.mozilla.org/r/13005/#review11591

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45be8c6659f4

Comment 8

[Mike Hommey [:glandium]]

https://reviewboard.mozilla.org/r/13005/#review11925

::: browser/config/tooltool-manifests/linux64/tsan.manifest:9
(Diff revision 1)
> +"filename": "setup.sh"

Just when I removed all setup.sh from tooltool manifests in bug 1182407 :(

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Attachment: Follow up to use the unpack feature of tooltool instead of setup.sh

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8633840 [details] [diff] [review]
Follow up to use the unpack feature of tooltool instead of setup.sh

Review of attachment 8633840 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f590b208d656

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/45be8c6659f4
https://hg.mozilla.org/mozilla-central/rev/f590b208d656