Add clang 3.6 builds for TSan

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Chris Manchester (Offline Dec 18-19), Assigned: Chris Manchester (Offline Dec 18-19))

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

I got as far as figuring out I don't have the appropriate permissions to upload to tooltool and wondering whether I should be able to run build-clang.py locally.
(Assignee)

Comment 1

3 years ago
rail, can you help me figure out how to do this? Thanks!
Flags: needinfo?(rail)
Sure!

We have a wiki page on how to build clang here: https://wiki.mozilla.org/ReleaseEngineering/How_To/Clang_update

Tooltool is described here: https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool

Let me know if the docs are missing something.
Flags: needinfo?(rail)
(Assignee)

Updated

3 years ago
Depends on: 1182238
(Assignee)

Comment 3

3 years ago
Created attachment 8632178 [details]
MozReview Request: Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail

Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail
Attachment #8632178 - Flags: review?(rail)
(Assignee)

Comment 4

3 years ago
I got a working build out of https://treeherder.mozilla.org/#/jobs?repo=try&revision=0266fc9845f6
Assignee: nobody → cmanchester
(Assignee)

Comment 5

3 years ago
(In reply to Rail Aliiev [:rail] from comment #2)
> Sure!
> 
> We have a wiki page on how to build clang here:
> https://wiki.mozilla.org/ReleaseEngineering/How_To/Clang_update
> 
> Tooltool is described here:
> https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool
> 
> Let me know if the docs are missing something.

The only hiccup was the VM was set up with gcc 4.7.2, but the build-clang script mentioned gcc 4.7.3.
Comment on attachment 8632178 [details]
MozReview Request: Bug 1181342 - tooltool manifests and build-clang config for clang 3.6 r=rail

https://reviewboard.mozilla.org/r/13005/#review11591

Ship It!
Attachment #8632178 - Flags: review?(rail) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/45be8c6659f4
Keywords: checkin-needed
https://reviewboard.mozilla.org/r/13005/#review11925

::: browser/config/tooltool-manifests/linux64/tsan.manifest:9
(Diff revision 1)
> +"filename": "setup.sh"

Just when I removed all setup.sh from tooltool manifests in bug 1182407 :(
(Assignee)

Comment 9

3 years ago
Created attachment 8633840 [details] [diff] [review]
Follow up to use the unpack feature of tooltool instead of setup.sh
Attachment #8633840 - Flags: review?(mh+mozilla)
Comment on attachment 8633840 [details] [diff] [review]
Follow up to use the unpack feature of tooltool instead of setup.sh

Review of attachment 8633840 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8633840 - Flags: review?(mh+mozilla) → review+

Comment 11

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f590b208d656
https://hg.mozilla.org/mozilla-central/rev/45be8c6659f4
https://hg.mozilla.org/mozilla-central/rev/f590b208d656
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.