1181395 - Make kClassName* constants in nsWindowsDef.h use wchar_t[] to avoid runtime conversion

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently, the kClass* constants in nsWindowsDef.h use `const char[]` type. However, we are currently using the Unicode version of Windows API, which means we have to do runtime conversion every time when we use those constants.

We should change them to type `const wchar_t[]` instead.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: another patch

This patch removes nsWindow::sDefaultMainWindowClass so that we can pass the literal strings everywhere without wrapping them in nsString in advance.

You can r+ either one as you like. I prefer this patch, though, because I don't see the static field makes any sense.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8630827 [details] [diff] [review]
another patch

I like this one too. Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64077f01ac16

Comment 5

[[e-mail]]

After this, I got errors. I use vc14rc.
widget/windows/nsWindow.cpp(757): error C2660: “nsAString_internal::AssignLiteral”: function does not take one parameters

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

(In reply to zhoubcfan from comment #5)
> After this, I got errors. I use vc14rc.
> widget/windows/nsWindow.cpp(757): error C2660:
> “nsAString_internal::AssignLiteral”: function does not take one parameters

Could you please file a bug blocking this bug and bug 1119082 and provide more detailed information there? Since we haven't officially started supporting VC14, this error shouldn't block landing of this bug anyway.

Comment 7

[[e-mail]]

OK. I filed Bug 1181912 .

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64077f01ac16