Closed
Bug 1181411
Opened 9 years ago
Closed 9 years ago
Test various kinds of expected aborts in PLDHashTable
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
6.40 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Currently TestPLDHashTable.cpp doesn't test some aborting cases. Using fork() it is possible to test these.
|
Assignee | |
Comment 1•9 years ago
|
||
On debug builds this is working well. I get MOZ_CRASH output and stack traces on the console. On opt builds it's a bit stranger. I don't get any crash-related output on the console, but when I run it locally the crash reporter pops up twice (once per crashy operation). Seems like I should avoid that, possibly by only running the crashy operations on debug builds? Even with the opt build weirdness, try looks good: https://mail.google.com/mail/u/0/#search/tryserver/14e70f3236f56eb6
Attachment #8631469 -
Flags: review?(mh+mozilla)
|
||
Updated•9 years ago
|
Attachment #8631469 -
Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0195c79ed6f3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•