Closed Bug 1181411 Opened 4 years ago Closed 4 years ago

Test various kinds of expected aborts in PLDHashTable

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

Currently TestPLDHashTable.cpp doesn't test some aborting cases. Using fork() it is possible to test these.
On debug builds this is working well. I get MOZ_CRASH output and stack traces
on the console.

On opt builds it's a bit stranger. I don't get any crash-related output on the
console, but when I run it locally the crash reporter pops up twice (once per
crashy operation). Seems like I should avoid that, possibly by only running the
crashy operations on debug builds?

Even with the opt build weirdness, try looks good:
https://mail.google.com/mail/u/0/#search/tryserver/14e70f3236f56eb6
Attachment #8631469 - Flags: review?(mh+mozilla)
Attachment #8631469 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0195c79ed6f3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.