Closed Bug 1181415 Opened 9 years ago Closed 9 years ago

[Contacts] Convert switches to use gaia-switch component

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S3 (24Jul)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

[gaia] KevinGrandon:bug_1181415_contacts_gaia_switch > mozilla-b2g:master
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
In preparation for moving away from building blocks and onto web components.
Comment on attachment 8630831 [details] [review]
[gaia] KevinGrandon:bug_1181415_contacts_gaia_switch > mozilla-b2g:master

Borja or Francisco - Could either of you guys review this initial gaia-switch usage inside of contacts? Thanks!

If this looks good I'll follow it up with another patch to remove switches.css and the remaining controls.
Attachment #8630831 - Flags: review?(francisco)
Attachment #8630831 - Flags: review?(borja.bugzilla)
Review ping?
Comment on attachment 8630831 [details] [review]
[gaia] KevinGrandon:bug_1181415_contacts_gaia_switch > mozilla-b2g:master

Just left a comment on gh.

Thanks Kevin!
Attachment #8630831 - Flags: review?(francisco)
Comment on attachment 8630831 [details] [review]
[gaia] KevinGrandon:bug_1181415_contacts_gaia_switch > mozilla-b2g:master

Good point Francisco! I've made the changes, please take a look if you have time. Thanks!
Attachment #8630831 - Flags: review?(francisco)
Comment on attachment 8630831 [details] [review]
[gaia] KevinGrandon:bug_1181415_contacts_gaia_switch > mozilla-b2g:master

Tested, and working perfectly, thanks Kevin
Attachment #8630831 - Flags: review?(francisco)
Attachment #8630831 - Flags: review?(borja.bugzilla)
Attachment #8630831 - Flags: review+
Landed:

https://github.com/mozilla-b2g/gaia/commit/ade1ef5249cfab921e00ed67b30f3d03c2e24b5e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: