1181453 - Amend https://bugzilla.mozilla.org/form.fxos.feature form

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Custom Bug Entry Forms, defect)

Description

[Doug Sherk (:drs) (inactive)]

The form would have the following fields:

    "Product Component" (select): [same as current form, but suggest using "Gaia::Feedback" instead of "General"]
    "This is a feature request"
        input[type="checkbox"])
        Description: "Is this a defect with existing functionality or a new feature request?"
        Sets "feature" keyword if checked.
    "Feature Request Summary"
        input[type="text"]
        required
        Same as current form, but slightly renamed.
    "Description of feature or problem to be solved"
        textarea
        required
        Same as current form.
    "Was this discussed in a mailing list?"
        input[type="checkbox"]
        Defaults to disabled. When checked, enables the following two fields.
    "Mailing list thread"
        input[type="text"]
        required
        Active only if "Was discussed in a mailing list?" is checked.
        Description: "The mailing list post where this was discussed. e.g. https://groups.google.com/a/mozilla.com/forum/#!topic/foxfood-feedback/eCg6KaVD4FE"
        Tied directly to the "URL" field.
    "Stakeholder email addresses"
        input[type="text"]
        List of Bugzilla account emails, with autocompletion.
        Active only if "Was discussed in a mailing list?" is checked.
        Description: "Anyone you think would like to follow this request. You may include people who discussed this in the mailing list thread, if there was one."
        Tied directly to "cc" field.
    Misc, set the following for all reports:
        "foxfood" keyword
        status: UNCONFIRMED
        status-b2g-master: affected
    At the end, write this:
        "Once your form has been submitted, a tracking bug will be created. We will then reach out for additional info and next steps. If you discussed this on a mailing list, please link the people there to this tracking bug. Thanks!"

Comment 1

[:glob ✱]

i've pushed an updated form to our development server for you to provide feedback upon:
https://bugzilla-dev.allizom.org/form.fxos.feature

> "This is a feature request"
>   input[type="checkbox"])
>   Description: "Is this a defect with existing functionality or a new  feature request?"
>   Sets "feature" keyword if checked.

i wasn't sure exactly what you meant by this, because this whole form is for collecting feature requests, so that checkbox should always be checked (ie. the bug would always relate to either a new or existing feature).

i guessed that you meant to classify the difference between new and existing, so that's what you see on the form.  the 'feature' keyword is added when you select 'new'.

Comment 2

[Doug Sherk (:drs) (inactive)]

This looks really good, but I noticed a few things:

1. It doesn't seem to always set the "foxfood" keyword.
   Also, it doesn't set the "feature" keyword when "New Feature Request" is set.

2. The following fields don't need to be included in the description, as they can be inferred from others:
>> Request Type
New Feature Request
>> Was this discussed in a mailing list?
Yes

3. "status-b2g-master: affected" isn't set. Strangely, the dev server is still using "status-b2g-v3.0", which should have been changed. Perhaps until we deploy the new form, we could just use "status-b2g-v3.0: affected" for testing purposes.

4. Is there a way that we could put Gaia::Feedback as the first component?

Thanks.

Comment 3

[Doug Sherk (:drs) (inactive)]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #2)
> 2. The following fields don't need to be included in the description, as
> they can be inferred from others:
> >> Was this discussed in a mailing list?
> Yes

Clarifying this, we never need to display the "Was this discussed in a mailing list?" field. We can just optionally display any inputted URL. If the user puts "No" for the "Was this discussed...?" field, then we don't insert any information about mailing lists into the report.

Comment 4

[:glob ✱]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #2)
> 1. It doesn't seem to always set the "foxfood" keyword.
> Also, it doesn't set the "feature" keyword when "New Feature Request" is set.

odd, i can't reproduce this issue.  do you see any javascript errors?

> 2. The following fields don't need to be included in the description, as
> they can be inferred from others:
> >> Request Type
> New Feature Request
> >> Was this discussed in a mailing list?
> Yes

removed.

> 3. "status-b2g-master: affected" isn't set. Strangely, the dev server is
> still using "status-b2g-v3.0", which should have been changed.

the dev server is a copy of production from may 2015, and we don't make administration changes to it unless needed.
i've created the status-b2g-master field.

> 4. Is there a way that we could put Gaia::Feedback as the first component?

done.


these changes are live on bugzilla-dev.

Comment 5

[Doug Sherk (:drs) (inactive)]

I got this error when trying to create a bug with that form:

You tried to update the status of the tracking flag 'cf_status_b2g_master' to 'Bugzilla::Extension::TrackingFlags::Flag::Value=HASH(0x7f277463d248)'. Only a user with the required permissions may make this change.

Could you give the appropriate permission to [e-mail]?

Comment 6

[:glob ✱]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #5)
> I got this error when trying to create a bug with that form:
> 
> You tried to update the status of the tracking flag 'cf_status_b2g_master'
> to 'Bugzilla::Extension::TrackingFlags::Flag::Value=HASH(0x7f277463d248)'.
> Only a user with the required permissions may make this change.
> 
> Could you give the appropriate permission to [e-mail]?

i can, but it setting that field means that anyone using this form needs to have 'canconfirm' rights in bugzilla, which makes it rather restrictive.

options:
- allow anyone to set cf_status_b2g_master to affected (on production and dev)
- require canconfirm rights to use this form
- don't set cf_status_b2g_master as part of this form

what do you want to do (i'd recommend the first one, and highly advise against the second).

Comment 7

[:glob ✱]

actually i want to get confirmation from dale before i adjust his account (i don't want to break bzlite testing).
dale - are you ok with [e-mail] being granted canconfirm on bugzilla-dev?

Comment 8

[Doug Sherk (:drs) (inactive)]

I agree, let's do the first option. We should allow anyone to set the status-* flags.

(In reply to Byron Jones ‹:glob› from comment #7)
> actually i want to get confirmation from dale before i adjust his account (i
> don't want to break bzlite testing).
> dale - are you ok with [e-mail] being granted canconfirm
> on bugzilla-dev?

If we do the first option, we don't need that. I think it's best if we don't, anyways.

Comment 9

[:glob ✱]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #8)
> I agree, let's do the first option. We should allow anyone to set the
> status-* flags.

because of the impact this change may have i'd like to get sign-off on this change.

kevin - are you ok with allowing anyone to set the b2g-status-* flags to any value?
currently everyone can set a flag to '?' but canconfirm is required to set it to any other value.

if this is ok i'll file a separate bug to track this change.

Comment 10

[:glob ✱]

over irc doug said that mahe was probably a better person to sign-off on the changes in comment 9, redirecting needinfo.

Comment 11

[Doug Sherk (:drs) (inactive)]

I'm still not seeing any keywords set. I'm not seeing any JS errors in my logs. Example:
https://bugzilla-dev.allizom.org/show_bug.cgi?id=1153711

I thought more about the status setting. Can we make it default to NEW if the person has canconfirm, and UNCONFIRMED if they don't? I was originally thinking that we'd use this as a way of marking bugs as triaged or not, but I think that would cause more confusion.

Also, one last nit-pick. There's an extra line break here:

>> Description of feature, or problem to be solved
aksdfjkasdf


>> Mailing list thread
https://groups.google.com/a/mozilla.com/forum/#!topic/foxfood-feedback/eCg6KaVD4FE

Comment 12

[Doug Sherk (:drs) (inactive)]

Hi Byron, any updates on this?

Comment 13

[Doug Sherk (:drs) (inactive)]

Oh, I forgot about Mahe having to sign off on this. I'll ask him about it on Monday.

Comment 14

[Doug Sherk (:drs) (inactive)]

Ok, Byron, let's just not set this field as part of this form.

Comment 15

[:glob ✱]

https://bugzilla-dev.allizom.org/form.fxos.feature updated with the changes from comment 11, plus removal of setting the b2g-status field.

i'm not sure what's going on with the keywords as i've been totally unable to reproduce that issue, so i moved setting them from the client browser to the server.

Comment 16

[Doug Sherk (:drs) (inactive)]

I'm still not getting the keywords when submitting a bug. See https://bugzilla-dev.allizom.org/show_bug.cgi?id=1153728

I wonder if it's because of my account not having the "canconfirm" permission? If so, is there anything we can do about that?

If not, can we needinfo "[e-mail]" when the user doesn't have "canconfirm"? We should probably chat on IRC about this.

Comment 17

[:glob ✱]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #16)
> I wonder if it's because of my account not having the "canconfirm"
> permission? If so, is there anything we can do about that?

urgh, so it looks like you can edit a bug to set keywords without editbugs rights, but not during bug creation.
i've filed bug 1186776 to remove that limitation.

Comment 18

[:glob ✱]

this was pushed out today.