[B2G] Do not collect layers data when memory-pressure is from process priority change

RESOLVED FIXED in Firefox 42

Status

()

Core
Graphics: Layers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kanru, Assigned: kanru)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1154231 we collect child process' layers data when we have memory-pressure. However we also issue a synthesized memory-pressure event when the child process is going to background which will kill the layers data that we want to keep.

http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ProcessPriorityManager.cpp#1097

The idea is to use a special reason for this particular (forced) memory pressure that do not flush things that affects the rendering.
(Assignee)

Comment 1

3 years ago
Created attachment 8633357 [details] [diff] [review]
Change the reason for memory-pressure fired during priority change
Attachment #8633357 - Flags: review?(gsvelto)
Comment on attachment 8633357 [details] [diff] [review]
Change the reason for memory-pressure fired during priority change

Review of attachment 8633357 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with a nit addressed: please add a description for this new message in the comment for the nsIMemory class to document this. See here:

http://hg.mozilla.org/mozilla-central/file/e786406bc683/xpcom/base/nsIMemory.idl#l25
Attachment #8633357 - Flags: review?(gsvelto) → review+
https://hg.mozilla.org/mozilla-central/rev/119f3f9c406f
Assignee: nobody → kanru
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.