1181533 - Windows build bustage in toolkit/components/downloads/nsDownloadManager.cpp with --disable-safe-browsing set

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I have --disable-parental-controls set in my .mozconfig. With bug 905127, I'm now seeing the below bustage:

toolkit/components/downloads/nsDownloadManager.cpp(84)   : error C2065: 'PR_USEC_PER_MSEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(1581) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(1840) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C2660: 'nsIDownloadManagerUI::Show' : function does not take 3 arguments
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C3861: 'NS_strcmp': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2605) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2724) : error C2065: 'PR_USEC_PER_MSEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(2725) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2960) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2969) : error C2065: 'PR_USEC_PER_SEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(3097) : error C3861: 'PR_Now': identifier not found

I've verified that commenting out the disable allows it to build successfully again.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Gah, that should have been --disable-safe-browsing. I wonder if this is a unified build issue.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Changing the moz.build entry for nsDownloadManager.cpp from UNIFIED_SOURCES to SOURCES didn't work.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: add prtime.h include to nsDownloadManager.cpp

When bug 905127 landed, it added the prtime.h include to nsDownloadScanner.cpp but not nsDownloadManager.cpp. I'm guessing it got missed due to some random unified build combo that is getting tickled by my disabling of safe browsing locally.

With that, I'm down to only 2 errors:
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C2660: 'nsIDownloadManagerUI::Show' : function does not take 3 arguments
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C3861: 'NS_strcmp': identifier not found

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: add nsCRTGlue.h and prtime.h includes to nsDownloadManager.cpp

And nsCRTGlue.h takes care of those!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d94ec89a241f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d94ec89a241f