[mobile][zh-TW][p12n] Update region.properties & searchplugin list

NEW
Assigned to

Status

Mozilla Localizations
zh-TW / Chinese (Traditional)
--
major
2 years ago
2 years ago

People

(Reporter: petercpg, Assigned: petercpg)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8630991 [details] [diff] [review]
1147.patch

This bug contains following changes:

Searchplugin List:
- Add bing, duckduckgo, Y! TW
- Change name of Wikipedia (zh) to its name in Chinese; Update logo
- Fork yahoo.xml from en-US, change the name to Chinese, and change the links to tw.search.yahoo.com

region.properties:
- Add Yahoo TW and Bing to browser.search.order
- Change browser.contentHandlers.types.0.title from "My Yahoo" to "My Yahoo!" in align with en-US
Attachment #8630991 - Flags: review?(francesco.lodolo)
Keywords: productization
Comment on attachment 8630991 [details] [diff] [review]
1147.patch

Review of attachment 8630991 [details] [diff] [review]:
-----------------------------------------------------------------

The most problematic part of this patch is Yahoo. If you want to add Yahoo in zh-TW, we need to figure out the proper way with BD. Cloning en-US is definitely not correct.

::: mobile/searchplugins/list.txt
@@ +1,3 @@
>  google
> +bing
> +duckduckgo

Given how few searchplugin zh-TW has, I don't think it's a problem to add DDG, but I need to check with the mobile team.

::: mobile/searchplugins/wikipedia-zh-TW.xml
@@ +3,4 @@
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
>  <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>維基百科</ShortName>

There's a reason for keeping "Wikipedia (zh)": consistency with the searchplugin exposed directly by Wikipedia in its page (and autodetected by Firefox).

If you change the shortName, Firefox will detect a new searchplugin on Wikipedia, ignoring the one installed.

<link rel="search" type="application/opensearchdescription+xml" href="/w/opensearch_desc.php" title="Wikipedia (zh)" />
Attachment #8630991 - Flags: review?(francesco.lodolo) → review-
(In reply to Francesco Lodolo [:flod] from comment #1)
> Comment on attachment 8630991 [details] [diff] [review]
> 1147.patch
> 
> Review of attachment 8630991 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The most problematic part of this patch is Yahoo. If you want to add Yahoo
> in zh-TW, we need to figure out the proper way with BD. Cloning en-US is
> definitely not correct.

We don't have contact here, so checking with BD would be fine. We can have either Yahoo or bing added, but as we ship Yahoo in Firefox Desktop, and it's more popular than Bing in Taiwan, Yahoo would be preferred. 

It will be another bug, but I'm also planning to update all Y! TW searchplugins for desktop. I'm wondering would they want to use the localized name (YAHOO!奇摩) instead of only YAHOO! for about:newtab images?

> 
> ::: mobile/searchplugins/list.txt
> @@ +1,3 @@
> >  google
> > +bing
> > +duckduckgo
> 
> Given how few searchplugin zh-TW has, I don't think it's a problem to add
> DDG, but I need to check with the mobile team.
> 
> ::: mobile/searchplugins/wikipedia-zh-TW.xml
> @@ +3,4 @@
> >     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> >  
> >  <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> > +<ShortName>維基百科</ShortName>
> 
> There's a reason for keeping "Wikipedia (zh)": consistency with the
> searchplugin exposed directly by Wikipedia in its page (and autodetected by
> Firefox).
> 
> If you change the shortName, Firefox will detect a new searchplugin on
> Wikipedia, ignoring the one installed.
> 
> <link rel="search" type="application/opensearchdescription+xml"
> href="/w/opensearch_desc.php" title="Wikipedia (zh)" />

I'm checking with Wikimedia-TW to see if we could have this line changed first. That title looks strange to general user.
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #2)
> It will be another bug, but I'm also planning to update all Y! TW
> searchplugins for desktop. I'm wondering would they want to use the
> localized name (YAHOO!奇摩) instead of only YAHOO! for about:newtab images?

Mike, can you give some guidance here?

The request would be to add Bing, DDG, and Yahoo on Fennec for zh-TW.
Space is not an issue, we currently only have Google and Wikipedia for this locale.

The point is: can we add Yahoo, and how? Should we localize the name (Yahoo -> Yahoo奇摩). 

en-US searchplugin is currently a lot different from the ones we ship for other locales. My guess would be to adapt one of the existing searchplugins to https://zh.search.yahoo.com

Example for French
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/file/402e4a4a5edb/mobile/searchplugins/yahoo-france.xml

As for desktop, I don't think we should start localizing images (are we still showing the larger ones in about:newtab? I don't think so)
Flags: needinfo?(mconnor)
In the meantime I've updated the icon for Wikipedia since this bug is taking a lot of time.
https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/9c2610907882
https://hg.mozilla.org/l10n-central/zh-TW/rev/32357b8f6fcd

Comment 5

2 years ago
**The request would be to add Bing, DDG, and Yahoo on Fennec for zh-TW.

We have the right to include Bing and DDG on Fennec for zh-TW.  Yahoo is on hold for now, but that might change after year-end.
Thanks Joanne.

Peter: do you want to create a patch to add DDG and Bing? I would also avoid making changes to region.properties, just add the 2 searchplugins to list.txt
Flags: needinfo?(mconnor)
Created attachment 8693139 [details] [diff] [review]
mob-searchplugins-bing-ddg.patch

This patch adds bing and duckduckgo to fennec first, will wait for Y! later.
Attachment #8630991 - Attachment is obsolete: true
Attachment #8693139 - Flags: review?(francesco.lodolo)
Comment on attachment 8693139 [details] [diff] [review]
mob-searchplugins-bing-ddg.patch

Review of attachment 8693139 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

One nit if you want: the order in this file is irrelevant, so I always suggest to use alphabetical order to make things more intuitive.

Remember to add a bug and review reference to your commit message, e.g. Bug 1181556: Add Bing and DDG to searchplugins for Fennec, r=flod
Attachment #8693139 - Flags: review?(francesco.lodolo) → review+
landed Comment 7 with Flod's suggestion search plugin order:

https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/3da6e2a2d6cc
https://hg.mozilla.org/l10n-central/zh-TW/rev/3da6e2a2d6cc

Let's keep this bug open for sometime...
You need to log in before you can comment on or make changes to this bug.