Closed
Bug 1181562
Opened 9 years ago
Closed 9 years ago
Fallback whitelist update: until July 29 2015
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(3 files, 1 obsolete file)
14.53 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
14.61 KB,
patch
|
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
14.58 KB,
patch
|
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1165549 +++ [Tracking Requested - why for this release]: periodical task to maintain the whitelist
Comment 1•9 years ago
|
||
Given that this is a mid-aug update and 40 ships on Aug 11 (RC builds on Aug 3), this is a wontfix for 40. We can take a fix in 41. Do you have a target date for the update?
status-firefox40:
--- → wontfix
status-firefox41:
--- → affected
status-firefox42:
--- → affected
tracking-firefox42:
--- → ?
Flags: needinfo?(VYV03354)
Assignee | ||
Comment 2•9 years ago
|
||
Corrected the date. I intended to land the patch on all branches.
Flags: needinfo?(VYV03354)
Summary: Fallback whitelist update: mid-August 2015 → Fallback whitelist update: 11 August 2015
Comment 3•9 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #2) > Corrected the date. I intended to land the patch on all branches. Aug 11 is the Firefox 40 release date. We cannot make code changes to 40 on that date. We're going to need a code change by July 29 (assuming it really is just an update to the list) in order for the change to ship in 40.
Flags: needinfo?(VYV03354)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(VYV03354)
Summary: Fallback whitelist update: 11 August 2015 → Fallback whitelist update: until July 29 2015
Updated•9 years ago
|
Whiteboard: [checkin on Jul 29]
Assignee | ||
Comment 4•9 years ago
|
||
* Added sites from bug 1126620 blockers and bug 1138101 blockers. * Removed fixed sites. * Removed following sites due to consistent connection errors or unknown host errors (please double check): https://escrowrefills.com https://learn.swosu.edu https://www.escrowrefills.com https://www.hankyu-club.com https://www.mercatoneuno.com https://www.mynpcdata.net
Comment on attachment 8636543 [details] [diff] [review] patch Review of attachment 8636543 [details] [diff] [review]: ----------------------------------------------------------------- LGTM except for www.mynpcdata.net. ::: security/manager/ssl/IntolerantFallbackList.inc @@ -453,5 @@ > "www.mpay.co.th", > "www.mtsindia.in", // RC4 > "www.my.airdo.jp", // bug 1129773 > "www.myagent.gov.ab.ca", // bug 1152827 > - "www.mynpcdata.net", I can connect to this host, but it still only works with fallback for me.
Attachment #8636543 -
Flags: review?(dkeeler) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/624abe520677
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [checkin on Jul 29]
Target Milestone: --- → mozilla42
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8636543 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Users can not connect some sites. [Describe test coverage new/current, TreeHerder]: tested locally and m-c [Risks and why]: Very low. Only trivial changes to static data. [String/UUID change made/needed]: none
Attachment #8636543 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8636543 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 9•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Users can not connect some sites. [Describe test coverage new/current, TreeHerder]: tested locally and m-c [Risks and why]: Very low. Only trivial changes to static data. [String/UUID change made/needed]: none
Attachment #8637806 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•9 years ago
|
||
Approval Request Comment See the above request comment for aurora. The only difference between this patch and the aurora patch is replacing "/security/manager/ssl/" with "/security/manager/ssl/src/". This is needed due to bug 1164714.
Attachment #8637808 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 11•9 years ago
|
||
Grrr, wrong patch attached. Sorry for the bugspam. Approval Request Comment See the above comment.
Attachment #8637806 -
Attachment is obsolete: true
Attachment #8637806 -
Flags: approval-mozilla-aurora?
Attachment #8637811 -
Flags: approval-mozilla-aurora?
Comment 12•9 years ago
|
||
Comment on attachment 8637808 [details] [diff] [review] patch for beta Glad to see many more removals than additions. Beta+ Aurora+
Attachment #8637808 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Attachment #8637811 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•