Closed Bug 1181562 Opened 5 years ago Closed 5 years ago

Fallback whitelist update: until July 29 2015

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox40 + fixed
firefox41 + fixed
firefox42 + fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(3 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1165549 +++

[Tracking Requested - why for this release]: periodical task to maintain the whitelist
Given that this is a mid-aug update and 40 ships on Aug 11 (RC builds on Aug 3), this is a wontfix for 40. We can take a fix in 41. Do you have a target date for the update?
Flags: needinfo?(VYV03354)
Corrected the date. I intended to land the patch on all branches.
Flags: needinfo?(VYV03354)
Summary: Fallback whitelist update: mid-August 2015 → Fallback whitelist update: 11 August 2015
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Corrected the date. I intended to land the patch on all branches.

Aug 11 is the Firefox 40 release date. We cannot make code changes to 40 on that date. We're going to need a code change by July 29 (assuming it really is just an update to the list) in order for the change to ship in 40.
Flags: needinfo?(VYV03354)
Flags: needinfo?(VYV03354)
Summary: Fallback whitelist update: 11 August 2015 → Fallback whitelist update: until July 29 2015
Attached patch patchSplinter Review
* Added sites from bug 1126620 blockers and bug 1138101 blockers.
* Removed fixed sites.
* Removed following sites due to consistent connection errors or unknown host errors (please double check):
https://escrowrefills.com
https://learn.swosu.edu
https://www.escrowrefills.com
https://www.hankyu-club.com
https://www.mercatoneuno.com
https://www.mynpcdata.net
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8636543 - Flags: review?(dkeeler)
Comment on attachment 8636543 [details] [diff] [review]
patch

Review of attachment 8636543 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM except for www.mynpcdata.net.

::: security/manager/ssl/IntolerantFallbackList.inc
@@ -453,5 @@
>    "www.mpay.co.th",
>    "www.mtsindia.in", // RC4
>    "www.my.airdo.jp", // bug 1129773
>    "www.myagent.gov.ab.ca", // bug 1152827
> -  "www.mynpcdata.net",

I can connect to this host, but it still only works with fallback for me.
Attachment #8636543 - Flags: review?(dkeeler) → review+
https://hg.mozilla.org/mozilla-central/rev/624abe520677
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [checkin on Jul 29]
Target Milestone: --- → mozilla42
Comment on attachment 8636543 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Users can not connect some sites.
[Describe test coverage new/current, TreeHerder]: tested locally and m-c
[Risks and why]: Very low. Only trivial changes to static data.
[String/UUID change made/needed]: none
Attachment #8636543 - Flags: approval-mozilla-aurora?
Attachment #8636543 - Flags: approval-mozilla-aurora?
Attached patch patch for aurora (obsolete) — Splinter Review
Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Users can not connect some sites.
[Describe test coverage new/current, TreeHerder]: tested locally and m-c
[Risks and why]: Very low. Only trivial changes to static data.
[String/UUID change made/needed]: none
Attachment #8637806 - Flags: approval-mozilla-aurora?
Attached patch patch for betaSplinter Review
Approval Request Comment

See the above request comment for aurora.

The only difference between this patch and the aurora patch is replacing "/security/manager/ssl/" with "/security/manager/ssl/src/". This is needed due to bug 1164714.
Attachment #8637808 - Flags: approval-mozilla-beta?
Attached patch patch for auroraSplinter Review
Grrr, wrong patch attached. Sorry for the bugspam.

Approval Request Comment
See the above comment.
Attachment #8637806 - Attachment is obsolete: true
Attachment #8637806 - Flags: approval-mozilla-aurora?
Attachment #8637811 - Flags: approval-mozilla-aurora?
Comment on attachment 8637808 [details] [diff] [review]
patch for beta

Glad to see many more removals than additions. Beta+ Aurora+
Attachment #8637808 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8637811 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1195789
You need to log in before you can comment on or make changes to this bug.