1181573 - when comparing two revisions on compare view, it would be nicer to have a description of the push without clicking on a link

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

the selection of revisions in compare chooser has been getting better, but human error is the last remaining cause of pain.

Assume you have a bunch of pushes in trying to narrow down a regression when we don't have an alert to give us a starting point. Now we want to find the one that is causing problems and send a compare view link in the bug.

The problem is with many revisions, it is easy to put the wrong revision in the old/new or just get the wrong revision.

Ideas to help out would be:
* show a pushlog view of changes in the compare view so we know which old and new are based on comments, etc.
* in the revision selection, have a way to show a pushlog or some type of query that has matching data (i.e. all try pushes with pusher=[e-mail])

Comment 1

[William Lachance (:wlach)]

Attachment: Screen Shot 2015-07-15 at 3.08.22 PM.png

To start with, what do you think of just printing a short summary of the revision? This should be easier to format now that the base/new is formatted as a list. Maybe something like the attached screenshot?

Comment 2

[William Lachance (:wlach)]

:MikeLing might be interested in this once we figure out what to do. :)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I think this is great and much better than before!

Comment 4

[MikeLing]

(In reply to William Lachance (:wlach) from comment #2)
> :MikeLing might be interested in this once we figure out what to do. :)

yep, I'm happy to work on this ;)

Comment 5

[MikeLing]

Attachment: PR for bug 1181573

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

Looks good, see PR for some minor requests for revisions and changes.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

Looks good, but same changes need to made in another place (sorry I missed that before). See PR for details.

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

I'd like to see the directive expanded so that we can remove more duplicated HTML from both templates. Looks good otherwise!

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

Seems like the subtest compare view is not working this time. Also a few other minor details I'd like to get cleaned up. :)

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

There seems to be a bug preventing the compare view from displaying properly with the latest PR applied. Also made some minor change requests. We're getting close though!

Comment 11

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

Missed some modifications requested last time + a request for one last small padding tweak.

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/aba6e1dea4ada924047cca9057d9e7d7ae6488c4
Bug 1181573 - show description of the push when comparing two revisions

Comment 13

[William Lachance (:wlach)]

Comment on attachment 8637091 [details] [review]
PR for bug 1181573

Fixes in PR moved this to an r+. \o/