Closed Bug 1181580 Opened 6 years ago Closed 6 years ago

Chat bubbles are in focus over context edit menu

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
1

Tracking

(firefox41 fixed, firefox42 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla42
Iteration:
42.3 - Aug 10
Tracking Flags:
Tracking Status
firefox41 --- fixed
firefox42 --- verified

People

(Reporter: bogdan_maris, Assigned: mikedeboer)

References

Details

(Whiteboard: [chat bug])

Attachments

(2 files)

Screenshot showing the issue
73.40 KB, image/png
Details
Patch v1: move the context edit form into the media view
5.53 KB, patch
dmose
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Affected builds:
- latest Aurora 41.0a2
- latest Nighty 42.0a1

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.10

STR:
1. Start Firefox
2. Tick 'Let's Talk about' and Start a conversation
4. Join the conversation
5. Write some text in chat textarea
6. Edit context


Expected results: Chat bubbles are seen in background.

Actual results: Chat bubbles are in focus over context edit page.

Notes:
- Screenshot showing the issue attached.
- This is not a regression, it reproduces since chat was enable by default.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Attachment #8631054 - Flags: review?(standard8)
Iteration: --- → 42.3 - Aug 10
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Rank: 20
Priority: -- → P2
Whiteboard: [chat] → [chat bug]
Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Sorry, didn't get around to this.
Attachment #8631054 - Flags: review?(standard8) → review?(dmose)
Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Review of attachment 8631054 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me; r=dmose
Attachment #8631054 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/14a52b82b274
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Verified that the issue does no longer reproduce using latest Nightly 42.0a1 across platforms (Windows 7 64-bit, Mac OS X 10.10.4 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
Flags: qe-verify+
Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Approval Request Comment
[Feature/regressing bug #]: Text chat layout changes
[User impact if declined]: Strange display when editing context and text chat bubbles are shown.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, views have test coverage.
[Risks and why]: Low, small change to layout to improve the display.
[String/UUID change made/needed]: None.
Attachment #8631054 - Flags: approval-mozilla-aurora?
Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Verified on Nightly. Aurora+
Attachment #8631054 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.