1181580 - Chat bubbles are in focus over context edit menu

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

Affected builds:
- latest Aurora 41.0a2
- latest Nighty 42.0a1

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.10

STR:
1. Start Firefox
2. Tick 'Let's Talk about' and Start a conversation
4. Join the conversation
5. Write some text in chat textarea
6. Edit context


Expected results: Chat bubbles are seen in background.

Actual results: Chat bubbles are in focus over context edit page.

Notes:
- Screenshot showing the issue attached.
- This is not a regression, it reproduces since chat was enable by default.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: move the context edit form into the media view

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Sorry, didn't get around to this.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Review of attachment 8631054 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me; r=dmose

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/14a52b82b274

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/14a52b82b274

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified that the issue does no longer reproduce using latest Nightly 42.0a1 across platforms (Windows 7 64-bit, Mac OS X 10.10.4 and Ubuntu 14.04 32-bit).

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Approval Request Comment
[Feature/regressing bug #]: Text chat layout changes
[User impact if declined]: Strange display when editing context and text chat bubbles are shown.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, views have test coverage.
[Risks and why]: Low, small change to layout to improve the display.
[String/UUID change made/needed]: None.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8631054 [details] [diff] [review]
Patch v1: move the context edit form into the media view

Verified on Nightly. Aurora+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/22dfa244c1d0