1181582 - [Windows 10] The separator displayed next to URLs with EVs attached should be solid

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Andrei Vaida [:avaida]]

Attachment: screenshot from Windows 10 x64 (10162)

Reproducible on:
* Nightly 42.0a1 (2015-07-07)
* Aurora 41.0a2 (2015-07-07)
* Beta 40.0b2 (20150706172413)

Affected platforms:
* Microsoft Surface Pro 2 - Windows 10 Pro x64 (Insider Preview Build 10162)

Steps to reproduce:
1. Launch Firefox.
2. Visit https://www.mozilla.org/
3. Check the styling of the separator displayed between the Extended Validation Certificate mark and the URL in the Location Bar.

Expected result:
The separator has a solid styling, as the ones from the tab strip and main toolbar.

Actual result:
The separator styling still reflects the old design.

Comment 1

[Justin Dolske [:Dolske]]

There are a number of similar P4ish separator bugs, but I'm going to call this one P2 because I've noticed it too, and it seems to jump out at me far more than the others for some reason.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I feel pretty strongly that we should just make this separator solid on all platforms. I don't think the gradient here is unique enough to keep per platform, and the gradient feels "old" in terms of modern design elements.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0492fa483509

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0492fa483509

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for Aurora41 and Beta40

Approval Request Comment
[Feature/regressing bug #]: Windows 10 UI changes
[User impact if declined]: separator between identity-box and URL won't match other platform styles
[Describe test coverage new/current, TreeHerder]: none, CSS-only change
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8636753 [details] [diff] [review]
Patch for Aurora41 and Beta40

Safe to uplift. Approved.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/25815ce3c29b

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8636753 [details] [diff] [review]
Patch for Aurora41 and Beta40

Let's get this small change on beta as well. Beta+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cddd49801dde

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Using a MS Pro 2 device running Windows 10 build 10240 I'm still seeing the old separator on https://www.mozilla.org.
Screenshot: http://i.imgur.com/dKDJoB3.png

Although, on several XUL pages (i.e. about:support) the separator is solid: http://i.imgur.com/x1RfHnO.png

Is there something I'm missing here?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Cornel Ionce [QA] from comment #10)
> Using a MS Pro 2 device running Windows 10 build 10240 I'm still seeing the
> old separator on https://www.mozilla.org.
> Screenshot: http://i.imgur.com/dKDJoB3.png
> 
> Although, on several XUL pages (i.e. about:support) the separator is solid:
> http://i.imgur.com/x1RfHnO.png
> 
> Is there something I'm missing here?

Those are both solid, but the background colors are different. This will be changed in Firefox 42 by bug 1186818.

Comment 12

[Andrei Vaida [:avaida]]

With Comment 11 taken into consideration, this is verified fixed on Beta 40.0b8 (20150727174134) and Nightly 42.0a1 (2015-07-28), using Windows 10 Pro x64 (Build 10240).

A potential issue I noticed on Aurora 41.0a2 (2015-07-28) is that the separator's height is too big on the dark theme, here's a screenshot - http://i.imgur.com/Rfi25GM.png. Jared, is this intended?

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Andrei Vaida, QA [:avaida] from comment #12)
> With Comment 11 taken into consideration, this is verified fixed on Beta
> 40.0b8 (20150727174134) and Nightly 42.0a1 (2015-07-28), using Windows 10
> Pro x64 (Build 10240).
> 
> A potential issue I noticed on Aurora 41.0a2 (2015-07-28) is that the
> separator's height is too big on the dark theme, here's a screenshot -
> http://i.imgur.com/Rfi25GM.png. Jared, is this intended?

That is not intended. Can you file a separate bug for that, and CC myself and :bgrins?

Comment 14

[Andrei Vaida [:avaida]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #13)
> That is not intended. Can you file a separate bug for that, and CC myself
> and :bgrins?
Sure, I've filed Bug 1188901 on this matter. Since it'll be treated separately, I'm closing this one.