1181648 - Sudden jerky pan/translation, when touching screen with second finger, in 3 different mapping apps (TomTom, Google, & Bing Maps)

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: Gaia::Customizer, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open TomTom Maps, Google Maps, or Bing Maps.
 2. Touch the screen with one finger. (don't remove it)
    (optional: pan around, to be sure your touch has taken effect)

 3. Touch the screen with another finger (e.g. to prepare for a multitouch zoom operation).

ACTUAL RESULTS:
The map has a sudden translation - the center immediately snaps downwards by an inch or so.

EXPECTED RESULTS:
No sudden translation.


Current Firefox Nightly for Android on a OnePlus One gives me EXPECTED RESULTS (with the Google Maps webapp).
My Firefox OS Z3C dogfooding device gives me ACTUAL RESULTS with Google Maps, Here Maps, and TomTom Maps.

I'm assuming this is a bug with the touch events being sent by Firefox OS, given that it reproduces on completely different mapping apps, and it doesn't reproduce in Firefox for Android.

Comment 1

[Daniel Holbert [:dholbert]]

Build info from check_versions.py:

Build ID               20150707033152
Gaia Revision          e6506d68e01489b57616f8b74e8773f938ce62b3
Gaia Date              2015-07-06 18:14:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e271ef4c49ae
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150619.015544
Firmware Date          Fri Jun 19 01:55:53 UTC 2015
Bootloader             s1

Comment 2

[Daniel Holbert [:dholbert]]

FWIW, I get EXPECTED RESULTS when performing the STR on...
 - a zoomed-in photo in the Gaia "Gallery" app.
 - a zoomed-in mostly-text web page (planet.m.o) in the Browser app.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I'm starting to wonder if this is a hardware issue with some devices. I added some logging locally to see what the touch event coordinates look like and I'm having a hard time reproducing the actual problem.

Is there anybody who can consistently reproduce any of this glitchy/jumpy zooming behaviour in the mapping apps and is also building their own Gecko? If so I can provide a patch to apply to log the touch events which would provide some useful information.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch to log touch coordinates

Here's the patch; feel free to apply it and reproduce the problem if you're able to.

Comment 6

[Daniel Holbert [:dholbert]]

(I'm not building my own Gecko, and am reluctant to do so because this is my primary personal phone, FWIW.)

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I can reproduce, and I'm willing to build locally with the patch.

Waiting on some instructions from :drs to understand the precise build flags needed for the foxfood devices.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch to log touch coordinates

Thanks. I updated the patch to enable another bit of logging, hopefully it will provide a bit more info if the bug is in our code somewhere.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:drs, I sent an email already, but if you could share build steps with me to create a foxfood build locally, I can move forward here.

Comment 10

[Doug Sherk (:drs) (inactive)]

For B2G:

./config.sh aries
B2G_UPDATER=1 DOGFOOD=1 GAIA_DISTRIBUTION_DIR=distros/spark VARIANT=userdebug ./build.sh

For just Gaia:

GAIA_DEV_PIXELS_PER_PX=2.25 MOZILLA_OFFICIAL=1 PRODUCTION=1 GAIA_DISTRIBUTION_DIR=distros/spark DOGFOOD=1 make reset-gaia

I'll put these instructions up somewhere more accessible for others. I'm leaving my needinfo set for that. Apologies for not replying to your email, I missed it.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Those of you who can reproduce this problem: can you go to Settings -> Addons, disable customizer (if it is enabled), restart the phone, and see if the issue still occurs?

Comment 12

[Michael Shal [:mshal]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #11)
> Those of you who can reproduce this problem: can you go to Settings ->
> Addons, disable customizer (if it is enabled), restart the phone, and see if
> the issue still occurs?

Disabling customizer & restarting fixes the issue for me. I tried both google maps & tomtom maps, and they both seem to work as expected.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Thanks! This is almost certainly the same issue as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1186635#c5 then.

Comment 14

[Daniel Holbert [:dholbert]]

I can also confirm that disabling Customizer (per comment 11) does fix this bug.

(However, it does not help with similar-ish bug 1177229.)

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Aries Touch Event Log

Disabling Customizer does seem to help for me too.

I had already captured a log (with Customizer enabled) before seeing the new comments here, so in case it helps, I've attached it here.

The y coordinate of the touch points in the log appears to jump around by 100px, so perhaps that's related here.

I'm happy to run any other experiments as needed.

Comment 16

[Doug Sherk (:drs) (inactive)]

We're retiring the Spark distro, so instructions are no longer needed for building it.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

And in fact this bug is no longer relevant since Customizer is no longer a thing.