1181649 - Date picker is broken in "Summarize Time" page

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[wskellenger]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36

Steps to reproduce:

Bugzilla 5.0rc3 (I can get the exact git commit I'm on if needed, my Bugzilla server console is not easily accessible at the moment), click on "Summarize Time" on an issue, which takes you to "summarize_time.cgi".  Then, click on one of the two date pickers there.


Actual results:

The date picker fails to open.  In Firefox, I see the following in the console:

Immediately when entering the page:
TypeError: this.oDomContainer is null 46bb713585ea9e39e63b7a8163cc9a65.js:13:5938  

...And after clicking on a date picker widget:
13:06:29.125 TypeError: calendar is undefined daf5e0fb6826e6a35280e622913f0c4a.js:242:0  

In Google Chrome, similar errors (however more verbose):

Immediately when entering the page:
Uncaught TypeError: Cannot read property 'ownerDocument' of nullf.init @ 46bb713585ea9e39e63b7a8163cc9a65.js:13f @ 46bb713585ea9e39e63b7a8163cc9a65.js:13createCalendar @ daf5e0fb6826e6a35280e622913f0c4a.js:226(anonymous function) @ summarize_time.cgi?id=5&do_depends=1:214

...And after clicking on a date picker widget:
Uncaught TypeError: Cannot read property 'oDomContainer' of undefinedshowCalendar @ daf5e0fb6826e6a35280e622913f0c4a.js:242onclick @ summarize_time.cgi?id=5&do_depends=1:163

I suspect there is some sort of js include missing in summarize_time.cgi.  The date pickers work on other pages, just not summarize_time.

My Bugzilla installation is running on Windows 7 if that matters.  If this can't be confirmed by others I will investigate more on my side...


Expected results:

Date picker should display.

Comment 1

[Frédéric Buclin]

Confirmed. This is broken in 5.0 and master. 4.4 is working fine.

Comment 2

[Frédéric Buclin]

Oops, I removed some empty <div></div> by accident in bug 840407 when doing cleanup.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Gervase Markham [:gerv]]

I just migrated machines and Bugzilla is not running yet, and I'm off on holiday until Tuesday. If this can't wait, you may need to find another reviewer. Otherwise, I'll review it when I get back, get Bugzilla running and can test it. (It looks fine.)

Gerv

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 8633495 [details] [diff] [review]
patch, v1

r=gerv.

Gerv

Comment 6

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   5e1fb17..bdc889f  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   95c3c88..7fec569  5.0 -> 5.0