Closed Bug 1181684 Opened 4 years ago Closed 4 years ago

Using a long email to sign into Sync screws up the layout of the hamburger menu.

Categories

(Firefox :: Sync, defect, P2)

35 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 42
Iteration:
42.1 - Jul 13
Tracking Status
firefox41 --- verified
firefox42 --- verified

People

(Reporter: ckarlof, Assigned: eoger)

References

Details

(Whiteboard: [fxsync])

Attachments

(3 files)

Screenshot attached.
Priority: -- → P2
eoger, it would be great to look at this while you're working on the hamburger menu stuff.
Assignee: nobody → edouard.oger
See Also: → 1181692
Here's the patch for this.
Attachment #8631160 - Flags: review?(markh)
And how it looks!
Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Review of attachment 8631160 [details] [diff] [review]:
-----------------------------------------------------------------

Gijs,
  This is a trivial patch, but my CSS foo is letting me down whether this is indeed the best way to solve this problem, so it would be great if you can have a look.
Attachment #8631160 - Flags: review?(markh) → review?(gijskruitbosch+bugs)
Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Review of attachment 8631160 [details] [diff] [review]:
-----------------------------------------------------------------

Well, just messing with the flexbox styles here doesn't seem to do anything, which I'm going to chalk up to "hello, XUL, we hate you too."

wfm!
Attachment #8631160 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Blocks: 1182288
Rank: 15
Iteration: --- → 42.1 - Jul 13
Blocks: 1139698
https://hg.mozilla.org/mozilla-central/rev/4b9160a4a8bc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: Users with a very long email address will see the layout of the hamburger menu messed up.
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8631160 - Flags: approval-mozilla-aurora?
Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Looks safe and fixes a pretty visible UI bug. Approved.
Attachment #8631160 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Contact: catalin.varga
Whiteboard: [fxsync]
Verified as fixed using the following environment:
FF 41 
Build Id: 20150804004026

FF 42
Build Id: 20150804030204
Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.