1181684 - Using a long email to sign into Sync screws up the layout of the hamburger menu.

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Chris Karlof [:ckarlof]]

Attachment: Screen Shot 2015-07-08 at 11.21.56 AM.png

Screenshot attached.

Comment 1

[Chris Karlof [:ckarlof]]

eoger, it would be great to look at this while you're working on the hamburger menu stuff.

Comment 2

[Edouard Oger [:eoger]]

Attachment: bug-1181684.patch

Here's the patch for this.

Comment 3

[Edouard Oger [:eoger]]

Attachment: Screen Shot 2015-07-08 at 11.49.00 AM.png

And how it looks!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Review of attachment 8631160 [details] [diff] [review]:
-----------------------------------------------------------------

Gijs,
  This is a trivial patch, but my CSS foo is letting me down whether this is indeed the best way to solve this problem, so it would be great if you can have a look.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Review of attachment 8631160 [details] [diff] [review]:
-----------------------------------------------------------------

Well, just messing with the flexbox styles here doesn't seem to do anything, which I'm going to chalk up to "hello, XUL, we hate you too."

wfm!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4b9160a4a8bc

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4b9160a4a8bc

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: Users with a very long email address will see the layout of the hamburger menu messed up.
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8631160 [details] [diff] [review]
bug-1181684.patch

Looks safe and fixes a pretty visible UI bug. Approved.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3580300f51dc

Comment 11

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:
FF 41 
Build Id: 20150804004026

FF 42
Build Id: 20150804030204
Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10