1181779 - "unable not make a phone call now" appears unnecessarily

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Ram Dayal Vaishnav [:ram]]

Attachment: 2015-06-15-00-02-29.png

When I am trying to make a call - Pop up "unable not make a phone call now" appear with message "Cannot make a phone call. If you are already dialing, please hang up first." (thought I am not already dialing).

Comment 1

[Gabriele Svelto [:gsvelto]]

Yes, this is a known issue, we should fix bug 1147735 for make this go away.

Comment 2

[Gabriele Svelto [:gsvelto]]

Hsin-Yi, I've got an STR for this issue that I don't really understand:

1. Make a call to a landline
2. Reply from the landline phone
3. Wait a few seconds, then hangup from the landline phone
4. On the DUT I get a disconnected event with |disconnectedReason| set to UnspecifiedError

I find this rather bizarre, first of all because from the RIL code I thought that |disconnectedReason| wouldn't have the "Error" bit and besides I didn't expect an error condition for this particular case. Does "UnspecifiedError" mean that there was no error after all? Maybe I'm interpreting the field incorrectly. BTW I can reproduce this with 100% success.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Gabriele Svelto [:gsvelto] from comment #2)
> Hsin-Yi, I've got an STR for this issue that I don't really understand:
> 
> 1. Make a call to a landline
> 2. Reply from the landline phone
> 3. Wait a few seconds, then hangup from the landline phone
> 4. On the DUT I get a disconnected event with |disconnectedReason| set to
> UnspecifiedError
> 
> I find this rather bizarre, first of all because from the RIL code I thought
> that |disconnectedReason| wouldn't have the "Error" bit and besides I didn't
> expect an error condition for this particular case. Does "UnspecifiedError"
> mean that there was no error after all? Maybe I'm interpreting the field
> incorrectly. BTW I can reproduce this with 100% success.

Hello Gabriele,
Your understanding is right - there should be no 'error' suffix when you retrieve the reason from telephonyCall.disconnectedReason. But you will find 'error' suffix in the gecko log. I experimented with the latest gaia&gecko, there's no "error" string per my observation.

If the call is released normally, the reason will be "normalCallClearing". "Unspecified" is reported from the network. Your STR 100% works for me as well, but I've seen real failed calls which were reported the "unspecified" error. So, I couldn't think of a way to distinguish this. :(

Comment 4

[Gabriele Svelto [:gsvelto]]

Thanks for clearing this up Hsin-Yi. I find this issue very annoying and I'm sure I'm not the only one so if you think it's OK I would make the dialer not show an error message when we receive an UnspecifiedError.

Because of this we'll be missing certain errors but I feel it's better that we miss a few errors rather than bug the user when no error actually happened. Besides I think that since the error is of the unspecified type we're not really informing the user much even when it's an actual error.