Closed Bug 1181781 Opened 9 years ago Closed 9 years ago

ReferenceError: target is not defined when performing a paste-and-search

Categories

(Firefox :: Search, defect)

39 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed
firefox42 --- fixed
firefox-esr38 --- unaffected

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
|target| here is defined in a separate block: https://dxr.mozilla.org/mozilla-central/source/browser/components/search/content/search.xml#525.
Attachment #8631253 - Flags: review?(adw)
Comment on attachment 8631253 [details] [diff] [review]
Patch

Review of attachment 8631253 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8631253 - Flags: review?(adw) → review+
Assignee: nobody → nhnt11
Approval Request Comment
[Feature/regressing bug #]: 1120957
[User impact if declined]: Users see an error in the console when performing a paste-and-search, and their search won't have a source set in Telemetry.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: very low risk, moves a variable declaration to an outer block.
[String/UUID change made/needed]: none
Attachment #8631253 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8631259 - Flags: review+
Attachment #8631259 - Flags: approval-mozilla-beta?
Attachment #8631259 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/88778e97874f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8631259 [details] [diff] [review]
Patch v1.0.0.0.1 (Updated commit message)

Low risk, easy fix, taking it.
Attachment #8631259 - Flags: approval-mozilla-beta?
Attachment #8631259 - Flags: approval-mozilla-beta+
Attachment #8631259 - Flags: approval-mozilla-aurora?
Attachment #8631259 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.