Closed Bug 1181787 Opened 6 years ago Closed 6 years ago

Write nodejs parser / transformer for things declared in apps' main html files

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gaye, Assigned: gaye)

References

Details

Attachments

(1 file, 4 obsolete files)

We have this terrible thing right now in gaia where apps can link (in html) to resources in shared/ and automagically have them included in their build directories. We also have to be able to rewrite apps' main html files with localized strings. We can write a little thing that runs on nodejs (perhaps with jsdom) to handle these html parsing and transformation tasks.
Blocks: 1181784
Attachment #8631725 - Flags: feedback?(rchien)
Attachment #8631725 - Flags: feedback?(gweng)
Attachment #8631725 - Flags: feedback?(eperelman)
Attachment #8631725 - Flags: feedback?(aus)
Assignee: nobody → gaye
Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

Looks pretty good to me. Comments and concerns in the pull request itself. :)
Attachment #8631725 - Flags: feedback?(aus) → feedback+
Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

No major concerns from me, just stylistic questions. :)
Attachment #8631725 - Flags: feedback?(eperelman) → feedback+
Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

Concerns are leaved in Github =)
Attachment #8631725 - Flags: feedback?(rchien) → feedback+
Gareth & Aus, 

I'm still wondering your feedback from my email. 

Hopefully you could give me some advices of the plan ((​​https://wiki.mozilla.org/Gaia/Build/NewBuildSystem) and then we could have an clear integration plan before implementing this tool! =)
Flags: needinfo?(gaye)
Flags: needinfo?(aus)
Hi Ricky, both of us will get back to you today on this.
Flags: needinfo?(aus)
Oh I think it's landed too quick and we can wait for greg's options and then set r? to us again.
Flags: needinfo?(gaye)
I believe no matter I have opinions or not, a review is necessary for landing patches. Although I actually left some on PR, which are mostly nits and needs of comments. And since I'm not a owner/peer of build system, feel free to discuss these with Ricky at the review process. Thanks!
Attachment #8631725 - Flags: feedback?(gweng) → feedback+
Revert https://github.com/mozilla-b2g/gaia/commit/65d25f459f400a29e0e230539409d109505c8e25

Sorry Gareth, I reverted this patch because I want to know why it is landed in tools/ instead of becoming a NPM module. And another one problem is there are still some nits leaved on Github but doesn't fix so please fix these nits first and set r? again. Thanks =)
(In reply to Ricky Chien [:rickychien] from comment #12)
> Revert
> https://github.com/mozilla-b2g/gaia/commit/
> 65d25f459f400a29e0e230539409d109505c8e25
> 
> Sorry Gareth, I reverted this patch because I want to know why it is landed
> in tools/ instead of becoming a NPM module. And another one problem is there
> are still some nits leaved on Github but doesn't fix so please fix these
> nits first and set r? again. Thanks =)

It is an npm module by virtue of the fact that it has a package.json. We're moving away from the model where we have a separate repo for each module. Try to think of repositories and packages orthogonally.
Flags: needinfo?(gaye)
Attachment #8631724 - Attachment is obsolete: true
Attachment #8631725 - Attachment is obsolete: true
Attachment #8635119 - Attachment is obsolete: true
Attachment #8636229 - Attachment is obsolete: true
Attachment #8636230 - Flags: review?(rchien)
Comment on attachment 8636230 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31045

r+ I saw Github comments have been fixed.
Attachment #8636230 - Flags: review?(rchien) → review+
I still want to see this land in Gaia and also publish to NPM server for our gaia-playground experiment. Finally, remember to land this patch =)
Flags: needinfo?(gaye)
Landed thing https://github.com/mozilla-b2g/gaia/commit/91f8e1b892dc4a7a7888052a55d92d386f2679ef
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(gaye)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.