1181787 - Write nodejs parser / transformer for things declared in apps' main html files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

We have this terrible thing right now in gaia where apps can link (in html) to resources in shared/ and automagically have them included in their build directories. We also have to be able to rewrite apps' main html files with localized strings. We can write a little thing that runs on nodejs (perhaps with jsdom) to handle these html parsing and transformation tasks.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1181787-nodejs-app-html-util > mozilla-b2g:master

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

Comment 3

[Aus Lacroix [:aus]]

Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

Looks pretty good to me. Comments and concerns in the pull request itself. :)

Comment 4

[:Eli Perelman]

Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

No major concerns from me, just stylistic questions. :)

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8631725 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30899

Concerns are leaved in Github =)

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Gareth & Aus, 

I'm still wondering your feedback from my email. 

Hopefully you could give me some advices of the plan ((​​https://wiki.mozilla.org/Gaia/Build/NewBuildSystem) and then we could have an clear integration plan before implementing this tool! =)

Comment 7

[Aus Lacroix [:aus]]

Hi Ricky, both of us will get back to you today on this.

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

First part landed on master! https://github.com/mozilla-b2g/gaia/commit/acf8597905dc1e4a3b2a9535eeb36827d58c56dc

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Oh I think it's landed too quick and we can wait for greg's options and then set r? to us again.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

I believe no matter I have opinions or not, a review is necessary for landing patches. Although I actually left some on PR, which are mostly nits and needs of comments. And since I'm not a owner/peer of build system, feel free to discuss these with Ricky at the review process. Thanks!

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:revert-bug-1181787 > mozilla-b2g:master

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Revert https://github.com/mozilla-b2g/gaia/commit/65d25f459f400a29e0e230539409d109505c8e25

Sorry Gareth, I reverted this patch because I want to know why it is landed in tools/ instead of becoming a NPM module. And another one problem is there are still some nits leaved on Github but doesn't fix so please fix these nits first and set r? again. Thanks =)

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

(In reply to Ricky Chien [:rickychien] from comment #12)
> Revert
> https://github.com/mozilla-b2g/gaia/commit/
> 65d25f459f400a29e0e230539409d109505c8e25
> 
> Sorry Gareth, I reverted this patch because I want to know why it is landed
> in tools/ instead of becoming a NPM module. And another one problem is there
> are still some nits leaved on Github but doesn't fix so please fix these
> nits first and set r? again. Thanks =)

It is an npm module by virtue of the fact that it has a package.json. We're moving away from the model where we have a separate repo for each module. Try to think of repositories and packages orthogonally.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1181787-nodejs-app-html-util > mozilla-b2g:master

Comment 15

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31045

Comment 16

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8636230 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31045

r+ I saw Github comments have been fixed.

Comment 17

[Ricky Chien [:rickychien] (inactive)]

I still want to see this land in Gaia and also publish to NPM server for our gaia-playground experiment. Finally, remember to land this patch =)

Comment 18

[Gareth Aye [:gaye] (back from PTO)]

Landed thing https://github.com/mozilla-b2g/gaia/commit/91f8e1b892dc4a7a7888052a55d92d386f2679ef