Closed Bug 1181829 Opened 9 years ago Closed 9 years ago

Add Upper Sorbian (hsb) and Lower Sorbian (dsb) to master and 2.2 builds

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1183379

People

(Reporter: theo, Assigned: theo)

Details

Attachments

(1 file)

Those two locales are ready and can be added to gaia builds so that they can be tested and shipped.

This bug is for adding the locales to languages_all.json file on master, 2.2, and 2.1 branches
Depends on: 1181826
Hi Michael,

I'm creating the patch to add hsb and dsb to the list of languages in Settings > Language in Firefox OS. I'd like to double check with you what the label should be for both locales.

On Desktop, here's what we seem to be using:
hsb: "Dolnoserbšćina"
dsb: "Hornjoserbsce"

Is that correct and what we should display to the user?
Currently I'm a little confused since the Pull Request that's adding hsb keyboard layout is labelling hsb as Hornjoserbšćina. https://github.com/mozilla-b2g/gaia/pull/26509/files#diff-cfd47347c3ff7b3719d34e00a5a43758R4

I guess we should make the locale name and keyboard name consistent, right? Let me know what we should display everywhere :)
Flags: needinfo?(milupo)
Hello Théo, no, it isn't correct, you mixed up the language names:

*h*sb: *H*ornjoserbšćina  - Upper Sorbian
*d*sb: *D*olnoserbšćina   - Lower Sorbian

So the Pull Request is right.

I propose to use the forms ending with -šćina. They are the names for the languages. Hornjoserbsce is an adverb meaning "in Upper Sorbian".

Thanks.
Flags: needinfo?(milupo)
Oops, I indeed mixed things up in my comment.
Thanks for the explanation Michael, I updated my PR as follow:

"dsb"       : "Dolnoserbšćina",
"hsb"       : "Hornjoserbšćina",
Comment on attachment 8631327 [details] [review]
[gaia] TheoChevalier:add-hsb-dsb > mozilla-b2g:master

Stas, would you mind giving it a look please?
Attachment #8631327 - Flags: review?(stas)
Summary: Add Upper Sorbian (hsb) and Lower Sorbian (dsb) to master, 2.2 and 2.1 builds → Add Upper Sorbian (hsb) and Lower Sorbian (dsb) to master and 2.2 builds
Attachment #8631327 - Flags: review?(stas)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
No longer blocks: 1145940
No longer depends on: 1181826
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: