1181834 - Migrate browser/devtools/fontinspector tests to shared-head.js

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Brian Grinstead [:bgrins]]

We should import shared-head.js in fontinspector/test/head.js and remove any newly unnecessary code after that.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1181834 - Migrate browser/devtools/fontinspector tests to shared-head.js;r=jryans

Bug 1181834 - Migrate browser/devtools/fontinspector tests to shared-head.js;r=jryans

Comment 2

[Brian Grinstead [:bgrins]]

Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa43aca243b2

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8631324 [details]
MozReview Request: Bug 1181834 - Migrate browser/devtools/fontinspector tests to shared-head.js;r=jryans

https://reviewboard.mozilla.org/r/12877/#review11469

::: browser/devtools/framework/test/shared-head.js:15
(Diff revision 1)
>  const DevToolsUtils = devtools.require("devtools/toolkit/DevToolsUtils");

Change to just `require`

::: browser/devtools/framework/test/shared-head.js:10
(Diff revision 1)
>  const {Promise: promise} = Cu.import("resource://gre/modules/Promise.jsm", {});

Can we change this to require("promise")?

Comment 4

[Brian Grinstead [:bgrins]]

Updated the reviewboard push to update the comments.  Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=887ddf8d7a7c

Comment 5

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/5d5c0e5eca9f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d5c0e5eca9f