Closed Bug 1181856 Opened 10 years ago Closed 9 years ago

Migrate browser/devtools/styleeditor tests to shared-head.js

Categories

(DevTools :: Style Editor, defect)

defect
Not set
normal

Tracking

(firefox42 affected)

RESOLVED WORKSFORME
Tracking Status
firefox42 --- affected

People

(Reporter: bgrins, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should import shared-head.js in styleeditor/test/head.js and remove any newly unnecessary code after that.
I unfortunately don't have time to push this further, but I did start to work on this. It's a little more complicated than just importing shared-head.js though. Some style-editor tests need to access the inspector's rule-view, and therefore, it makes sense to import the head.js from the inspector/rules/test directory instead (which itself imports the head.js from inspector/test, which itself imports shared-head.js), in order to remove code duplication. This is what this patch does, and it's really close too. I think there was one remaining test failing.
This appears to be done now. The style-editor's tests include the inspector's shared head file, which itself includes the shared-head.js file
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: