1181874 - devtools.chrome.enabled and devtools.debugger.remote-enabled shouldn't be set to true by default in Developer Edition

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

We have sticky_prefs for devtools.chrome.enabled and devtools.debugger.remote-enabled so that they can have different values in DE / non-DE:

https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#815
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#825

I don't see any great reason why these should be turned on for the majority of our Dev Edition users, they are only applicable to browser or addon devs.

Comment 1

[Brian Grinstead [:bgrins]]

Jeff/Ryan, do you remember any reason why we enable these prefs in Dev Edition?  Have any objections to flipping these back to false by default?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

As you say, they only matter for browser / add-on devs.  Maybe we wanted to just skip a step for add-on devs?  Not sure.  Anyway, flipping back to false in DE seems fine to me.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1181874 - Set defaults for devtools.chrome.enabled and devtools.debugger.remote-enabled to false in Dev Edition;r=jryans

Bug 1181874 - Set defaults for devtools.chrome.enabled and devtools.debugger.remote-enabled to false in Dev Edition;r=jryans

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8631356 [details]
MozReview Request: Bug 1181874 - Set defaults for devtools.chrome.enabled and devtools.debugger.remote-enabled to false in Dev Edition;r=jryans

https://reviewboard.mozilla.org/r/12895/#review11449

Ship It!

Comment 5

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/7612059fedb7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7612059fedb7

Comment 7

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> As you say, they only matter for browser / add-on devs.  Maybe we wanted to
> just skip a step for add-on devs?  Not sure.  Anyway, flipping back to false
> in DE seems fine to me.

I think what I wanted was for add-on debugging to be enabled by default. I think that's reasonable, but should be separated maybe from chrome / remote debugging. Not a huge priority.

The other idea I have around the remote debugging pref was allowing people to easily remote automate firefox by using --start-debugger-server <PORT> and harth's firefox-client node module.

Comment 8

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Aurora 41.0a2 (2015-07-08) on ubuntu 14.04 LTS, 32 bit!

Build ID: 20150708004005
User Agent: Mozilla/5.0 (X11; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0

The bug's fix is now verified on Latest Beta 42.0b2(2015-09-28)!

Build ID: 20150928102225
User Agent: Mozilla/5.0 (X11; Linux i686; rv:42.0) Gecko/20100101 Firefox/42.0

[bugday-20151014]

Comment 9

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Aurora 41.0a2 (Build ID: 20150708004005) on 
windows 8.1 64-bit with the instructions from comment 0 .

Verified as fixed with Firefox Aurora 44.0a2 (Build ID: 20151105004045).

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

Verified as fixed with Firefox Nightly 45.0a1 (Build ID: 20151105030433).

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

As it is also verified on ubuntu (Comment 8), I am marking this bug as verified.