1181883 - add serializer on MediaDeviceInfo

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Back Aug 24 [:jib]]

Per https://github.com/w3c/mediacapture-main/pull/179

Comment 1

[Back Aug 24 [:jib]]

Attachment: MozReview Request: Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

Bug 1181883 - add serializer on MediaDeviceInfo

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8631379 [details]
MozReview Request: Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

https://reviewboard.mozilla.org/r/12909/#review11487

::: dom/media/tests/mochitest/test_enumerateDevices.html:37
(Diff revision 1)
> +    is(JSON.parse(JSON.stringify(devices))[0].deviceId, devices[0].deviceId,

Please test that .kind is also something expected - just because it is dictinary and not DOMString like the other properties.

Comment 3

[Back Aug 24 [:jib]]

(In reply to Olli Pettay [:smaug] from comment #2)
> Please test that .kind is also something expected - just because it is
> dictinary and not DOMString like the other properties.


.kind is a webidl enum, which is also a string in JS right?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

enum is enum. bindings layer deal those quite differently to DOMString.

Comment 5

[Back Aug 24 [:jib]]

Comment on attachment 8631379 [details]
MozReview Request: Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

https://reviewboard.mozilla.org/r/12909/#review11537

Ship It!

Comment 6

[Back Aug 24 [:jib]]

Comment on attachment 8631379 [details]
MozReview Request: Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

Comment 7

[Back Aug 24 [:jib]]

Comment on attachment 8631379 [details]
MozReview Request: Bug 1181883 - add serializer on MediaDeviceInfo. r=smaug

https://reviewboard.mozilla.org/r/12909/#review11679

Ship It!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19c676f9f8e9

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/19c676f9f8e9