1181895 - Fix fallout from bug 905127 due to missing headers for suite/

Reporter

Description

•

9 years ago

Once bug 1181434 is fixed, this bug will cover the code for suite/.

Rationale: Folding libsuite into xul requires quite a bit of change
to the code (particularly now that suite/ isn't non-Mozilla_internal,
we can now use nsString.h instead of nsStringAPI.h.)

Now the question that I'd like to pose is whether or not this is
the 'right' thing to do.  Being ignorant in why libsuite was
kept separate from libxul,  does it make sense to fold it into
libxul? 



+++ This bug was initially created as a clone of Bug #1181434 +++

Current trunk bustage:


libmailnews_extensions_mdn_src.a.desc
rm -f libmailnews_extensions_mdn_src.a
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_gen.py -o libmailnews_extensions_mdn_src.a.desc nsMsgMdnGenerator.o  
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/extensions/mdn/src'
make[4]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/base/util'
mkdir -p '.deps/'
Services.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o Services.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/Services.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/Services.cpp
nsImapMoveCoalescer.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgFilterList.o -c -I../../../../dist/stl_wrappers -I../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/search/src -I.  -I../../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MP -MF .deps/nsMsgFilterList.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/search/src/nsMsgFilterList.cpp
nsMsgFilterService.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsImapMoveCoalescer.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsImapMoveCoalescer.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsImapMoveCoalescer.cpp
nsMsgCompressIStream.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsLocalUtils.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/local/src -I.  -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsLocalUtils.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/local/src/nsLocalUtils.cpp
nsMailboxProtocol.o
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp: In member function ‘char nsMsgFilterList::ReadChar(nsIInputStream*)’:
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:385:24: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:389:15: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp: In member function ‘nsresult nsMsgFilterList::LoadTextFilters(nsIInputStream*)’:
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:704:65: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
make[4]: *** [nsMsgFilterList.o] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/base/search/src'
make[3]: *** [mailnews/base/search/src/target] Error 2
make[3]: *** Waiting for unfinished jobs....
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMailboxProtocol.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/local/src -I.  -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMailboxProtocol.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/local/src/nsMailboxProtocol.cpp
nsMailboxServer.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgCompressIStream.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgCompressIStream.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgCompressIStream.cpp
nsMsgCompressOStream.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o StructuredClone.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bindings -I. -I../../dist/include/mozilla/dom -I/builds/slave/c-cen-t-lnx/build/objdir/ipc/ipdl/_ipdlheaders -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/base -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/battery -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bluetooth -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/camera -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/canvas -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/geolocation -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/html -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/indexedDB -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/media/webaudio -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/media/webspeech/recognition -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/svg -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/workers -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xbl -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xml -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xslt/base -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xslt/xpath -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xul -I/builds/slave/c-cen-t-lnx/build/mozilla/js/xpconnect/src -I/builds/slave/c-cen-t-lnx/build/mozilla/js/xpconnect/wrappers -I/builds/slave/c-cen-t-lnx/build/mozilla/layout/style -I/builds/slave/c-cen-t-lnx/build/mozilla/layout/xul/tree -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/signaling/src/common/time_profiling -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/signaling/src/peerconnection -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bluetooth/bluetooth2 -I../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/StructuredClone.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe -Wno-uninitialized  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer      /builds/slave/c-cen-t-lnx/build/mozilla/dom/bindings/StructuredClone.cpp
Unified_cpp_dom_bindings0.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgCompressOStream.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgCompressOStream.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgCompressOStream.cpp
nsMsgDBFolder.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgDBFolder.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgDBFolder.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgDBFolder.cpp
nsMsgFileStream.o
../../../../mailnews/local/src/nsMailboxProtocol.cpp: In member function ‘virtual nsresult nsMailboxProtocol::OnStopRequest(nsIRequest*, nsISupports*, nsresult)’:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:341:32: error: invalid use of incomplete type ‘class nsIInputStreamPump’
In file included from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:29:0:
../../../dist/include/nsNetUtil.h:33:7: error: forward declaration of ‘class nsIInputStreamPump’
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: error: no match for ‘operator=’ in ‘((nsMailboxProtocol*)this)->nsMailboxProtocol::<anonymous>.nsMsgProtocol::m_request = pump’
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note: candidates are:
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:542:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsCOMPtr<T>&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:542:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsCOMPtr<nsIRequest>&’
../../../dist/include/nsCOMPtr.h:548:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(T*) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:548:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsIRequest*’
../../../dist/include/nsCOMPtr.h:557:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(already_AddRefed<U>&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:557:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘already_AddRefed<T>’
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:569:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(already_AddRefed<U>&&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:569:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘already_AddRefed<T>’
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:580:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsQueryInterface) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:580:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsQueryInterface’
../../../dist/include/nsCOMPtr.h:587:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsQueryInterfaceWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:587:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsQueryInterfaceWithError&’
../../../dist/include/nsCOMPtr.h:594:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsGetServiceByCID) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:594:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsGetServiceByCID’
../../../dist/include/nsCOMPtr.h:601:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsGetServiceByCIDWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:601:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsGetServiceByCIDWithError&’
../../../dist/include/nsCOMPtr.h:608:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsGetServiceByContractID) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:608:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsGetServiceByContractID’
../../../dist/include/nsCOMPtr.h:615:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsGetServiceByContractIDWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:615:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsGetServiceByContractIDWithError&’
../../../dist/include/nsCOMPtr.h:623:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsCOMPtr_helper&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:623:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsCOMPtr_helper&’
../../../dist/include/nsCOMPtr.h:632:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(const mozilla::dom::OwningNonNull<U>&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:632:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘const mozilla::dom::OwningNonNull<U>’
make[4]: *** [nsMailboxProtocol.o] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/local/src'
make[3]: *** [mailnews/local/src/target] Error 2

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Assignee: nobody → ewong

Status: NEW → ASSIGNED

Edmund Wong (:ewong)

Reporter

Comment 1

•

9 years ago

Any thoughts or opinions?

Flags: needinfo?(Pidgeot18)

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Flags: needinfo?(kairo)

Flags: needinfo?(iann_bugzilla)

Flags: needinfo?(bugspam.Callek)

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Flags: needinfo?(neil)

neil@parkwaycc.co.uk

Comment 2

•

9 years ago

Attached patch Untested patch (obsolete) — Details — Splinter Review

Flags: needinfo?(neil)

neil@parkwaycc.co.uk

Comment 3

•

9 years ago

Bah, why did that submit before I could type a comment?

I think libsuite was originally separate as part of the libxul build support. Now that libxul no longer exists, that's no longer a consideration. Note however that the internal and external string API are not the same so you can't simply replace nsStringAPI.h with nsStringGlue.h and expect things to work.

The other approach is to use something like the above patch to expand that function call.

Robert Kaiser

Comment 4

•

9 years ago

I defer to Neil on this, he knows way more about those issues than I probably ever will.

Flags: needinfo?(kairo)

neil@parkwaycc.co.uk

Comment 5

•

9 years ago

(In reply to comment #3)
> The other approach is to use something like the above patch to expand that
> function call.

Oh, I overlooked that there were actually two unresolved externals there.

neil@parkwaycc.co.uk

Comment 6

•

9 years ago

Attached patch Possible patch — Details — Splinter Review

With typos fixed and both unresolved externals rewritten.

Attachment #8631529 - Attachment is obsolete: true

Philip Chee

Assignee

Comment 7

•

9 years ago

Attached patch Patch v1.0 Fix build bustage. (obsolete) — Details — Splinter Review

(In reply to neil@parkwaycc.co.uk from comment #5)
> (In reply to comment #3)
> > The other approach is to use something like the above patch to expand that
> > function call.
> 
> Oh, I overlooked that there were actually two unresolved externals there.
I noticed that.

> -    nsCOMPtr<nsISupports> supports;
> -    rv = dirIterator->GetNext(getter_AddRefs(supports));
> -    dirEntry = do_QueryInterface(supports);
> +    nsCOMPtr<nsISupports> supports;
> +    rv = dirIterator->GetNext(getter_AddRefs(supports));
> +    dirEntry = do_QueryInterface(supports);
Fix some stray DOS line endings.

Attachment #8631797 - Flags: review?(neil)

Philip Chee

Assignee

Updated

•

9 years ago

Flags: needinfo?(iann_bugzilla)

Flags: needinfo?(bugspam.Callek)

Flags: needinfo?(Pidgeot18)

Hartmut Figge

Comment 8

•

9 years ago

(In reply to Philip Chee from comment #7)
> Patch v1.0 Fix build bustage.

Nice to be able to complete a build of my SM-Trunk x86_64. :)

neil@parkwaycc.co.uk

Comment 9

•

9 years ago

Comment on attachment 8631797 [details] [diff] [review]
Patch v1.0 Fix build bustage.

>     if (NS_SUCCEEDED(rv) && exists) {
>       // After all that let's just get the URL spec and set the pref to it.
>-      rv = NS_GetURLSpecFromFile(aFile, fileURL);
>+      if (fileHandler)
>+        rv = fileHandler->GetURLSpecFromFile(file, fileURL);
>       if (NS_FAILED(rv))
>         return NS_OK;
>       rv = aBranch->SetCharPref(aTransform->sourcePrefName, fileURL.get());
This looks as if it's based on my first patch but the problem here is that if fileHandler isn't set then rv will stay succeeded and you'll crash.

Attachment #8631797 - Flags: review?(neil) → review-

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Assignee: ewong → philip.chee

Philip Chee

Assignee

Comment 10

•

9 years ago

Attached patch Patch v2.0 fix harder. (obsolete) — Details — Splinter Review

(In reply to neil@parkwaycc.co.uk from comment #9)
> This looks as if it's based on my first patch but the problem here is that
> if fileHandler isn't set then rv will stay succeeded and you'll crash.
Fixed.

Not sure how to test this. Nothing seems to call SetFile()

Attachment #8631797 - Attachment is obsolete: true

Attachment #8632940 - Flags: review?(neil)

neil@parkwaycc.co.uk

Comment 11

•

9 years ago

Comment on attachment 8632940 [details] [diff] [review]
Patch v2.0 fix harder.

>+    nsCOMPtr<nsIProtocolHandler> handler;
>+    nsCOMPtr<nsIIOService> ioService(do_GetIOService());
>+    NS_ENSURE_TRUE(ioService, NS_ERROR_UNEXPECTED);
Would need to return NS_OK in the unlikely event that this fails.

>+    if (ioService)
Don't need to test twice.

>+    if (NS_FAILED(rv))
>+      return NS_OK;
>+    nsCOMPtr<nsIFileProtocolHandler> fileHandler(do_QueryInterface(handler, &rv));
Nit: do_QueryInterface doesn't crash if handler is null, it just errors out anyway.

>-      if (NS_FAILED(rv))
>-        return NS_OK;  
...
>+    if (NS_FAILED(rv))
>+      return NS_OK;
Why move this?

neil@parkwaycc.co.uk

Comment 12

•

9 years ago

(In reply to Philip Chee from comment #10)
> Nothing seems to call SetFile()

And that's unlikely to change in the future, so you could just remove it.

Philip Chee

Assignee

Comment 13

•

9 years ago

Attached patch Patch v3.0 more nits fixed — Details — Splinter Review

>>+    nsCOMPtr<nsIProtocolHandler> handler;
>>+    nsCOMPtr<nsIIOService> ioService(do_GetIOService());
>>+    NS_ENSURE_TRUE(ioService, NS_ERROR_UNEXPECTED);
> Would need to return NS_OK in the unlikely event that this fails.
Fixed.

>>+    if (ioService)
> Don't need to test twice.
Fixed.

>>+    if (NS_FAILED(rv))
>>+      return NS_OK;
>>+    nsCOMPtr<nsIFileProtocolHandler> fileHandler(do_QueryInterface(handler, &rv));
> Nit: do_QueryInterface doesn't crash if handler is null, it just errors out anyway.
Fixed.

>>-      if (NS_FAILED(rv))
>>-        return NS_OK;  
> ...
>>+    if (NS_FAILED(rv))
>>+      return NS_OK;
> Why move this?
Moved back.

Attachment #8632940 - Attachment is obsolete: true

Attachment #8632940 - Flags: review?(neil)

Attachment #8633695 - Flags: review?(neil)

neil@parkwaycc.co.uk

Updated

•

9 years ago

Attachment #8633695 - Flags: review?(neil) → review+

Edmund Wong (:ewong)

Reporter

Comment 14

•

9 years ago

Comment on attachment 8633695 [details] [diff] [review]
Patch v3.0 more nits fixed

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/8553f134b4e3

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Status: ASSIGNED → RESOLVED

Closed: 9 years ago

Resolution: --- → FIXED

Target Milestone: --- → seamonkey2.39

Edmund Wong (:ewong)

Reporter

Updated

•

9 years ago

Blocks: 1187602

Untested patch 9 years ago neil@parkwaycc.co.uk 2.45 KB, patch		Details \| Diff \| Splinter Review
Possible patch 9 years ago neil@parkwaycc.co.uk 2.46 KB, patch		Details \| Diff \| Splinter Review
Patch v1.0 Fix build bustage. 9 years ago Philip Chee 5.79 KB, patch	neil : review-	Details \| Diff \| Splinter Review
Patch v2.0 fix harder. 9 years ago Philip Chee 6.02 KB, patch		Details \| Diff \| Splinter Review
Patch v3.0 more nits fixed 9 years ago Philip Chee 5.96 KB, patch	neil : review+	Details \| Diff \| Splinter Review