1181963 - ssl_error_unsupported_version error page has too many stop signs

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[:glob ✱]

Attachment: Screenshot 2015-07-07 22.54.49.png

the error page ssl_error_unsupported_version error page has many stop signs.  many many stop signs.  some would say there are too many stop signs.

eg. https://mtsindia.in/

Comment 1

[Dave Garrett]

Tested in new profiles under Linux. Reproduced in Nightly 42 & Aurora 41, but no issue in Beta 40.

Comment 2

[:Cykesiopka]

11:56.99 LOG: MainThread Bisector INFO Last good revision: bea6758824d9
11:56.99 LOG: MainThread Bisector INFO First bad revision: 6b20dd2e20cc
11:56.99 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bea6758824d9&tochange=6b20dd2e20cc

Looks like Bug 1147438, based on manually reverting the changes done there on a local m-i build.

Comment 3

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Serious UI regression.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I agree it is indeed "toooo many" stop signs. Tracking for FF41 and 42.

Comment 5

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1181963 - ssl v3 error has too many stop signs, r?jaws

Bug 1181963 - ssl v3 error has too many stop signs, r?jaws

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8632006 [details]
MozReview Request: Bug 1181963 - ssl v3 error has too many stop signs, r?jaws

https://reviewboard.mozilla.org/r/12989/#review11563

Ship It!

::: browser/base/content/aboutNetError.xhtml:168
(Diff revision 1)
> -          errTitle.setAttribute("sslv3", "true");
> +          document.getElementById("errorTitle").setAttribute("sslv3", "true");

rs=me, but this function is pretty confusing with the errTitle variable being used for the descriptive text. I think it would be better if it was renamed to errTitleTextMessage or something. (Running out of names for all of the nested containers plus the actual text)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a1dde2c7ac76

Comment 8

[:Gijs (he/him)]

Comment on attachment 8632006 [details]
MozReview Request: Bug 1181963 - ssl v3 error has too many stop signs, r?jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1147438
[User impact if declined]: quite a lot of stop signs in the wrong place
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, minor CSS/JS change, we're still new to aurora 41.
[String/UUID change made/needed]: nope

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a1dde2c7ac76

Comment 10

[Kate Glazko]

Comment on attachment 8632006 [details]
MozReview Request: Bug 1181963 - ssl v3 error has too many stop signs, r?jaws

Minor risk CSS/JS change.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40139fab6775

Comment 12

[Nazir Ahmed Sabbir [:NaSb]]

I have successfully reproduced the bug in Nightly 42.0a1 (2015-07-08)(Build ID: 20150708030204) on Linux x64 by following comment 0's instruction!

Bug is now fixed on Latest Nightly 42.0a1 (2015-07-21) (Build ID: 20150721030212) and

Latest Aurora 41.0a2 (2015-07-21) (Build ID: 20150721004010)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

Comment 13

[Rezaul Huque Nayeem]

Reproduced this bug in Nightly 42.0a1 (2015-07-08)(Build ID: 20150708030204) on Windows 10 x64 by following comment 0!

The bug is fixed on Latest Nightly 42.0a1 (2015-07-21) (Build ID: 20150721030212),
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0

Latest Aurora 41.0a2 (2015-07-21) (Build ID: 20150721004010),
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0

[bugday-20150722]

Comment 14

[Nazir Ahmed Sabbir [:NaSb]]

It is verified on Linux and Windows (Comment 12 and Comment 13), Marking it as verified!