Closed Bug 1181976 Opened 4 years ago Closed 4 years ago

Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change

Categories

(Core :: Layout, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: flod, Assigned: BenWa)

References

Details

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/diff/6882b193f008/dom/locales/en-US/chrome/dom/dom.properties

-WillChangeBudgetWarning=Will-change memory consumption is too high. Surface area covers %1$S pixels, budget is the document surface area multiplied by %2$S (%3$S pixels). All occurences of will-change in the document are ignored when over budget.
+WillChangeBudgetWarning=Will-change memory consumption is too high. Surface area covers %1$S pixels, budget is the document surface area multiplied by %2$S (%3$S pixels). Occurences of will-change over the budget will be ignored.

At the end the string changed from "All occurences of will-change in the document are ignored when over budget." to "Occurences of will-change over the budget will be ignored.".

That's a significant change in meaning, not just a cosmetic one, and needs a new string ID.

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings
Summary: Rename WillChangeBudgetWarning to reflect string change → Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change
BenWa, can you take this?
Flags: needinfo?(bgirard)
Ok, I had assumed that the string change itself was sufficient to be picked up or that the reviewer would catch it.

I'll make the change and keep that in mind next time.
Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod
Attachment #8637463 - Flags: review?(francesco.lodolo)
Assignee: nobody → bgirard
Comment on attachment 8637463 [details]
MozReview Request: Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod

https://reviewboard.mozilla.org/r/13873/#review12493

I'm not familiar at all with c++ code: if you can confirm that the .cpp change is expected, this is good to go with the change pixels->px.

::: dom/locales/en-US/chrome/dom/dom.properties:160
(Diff revision 1)
> -WillChangeBudgetWarning=Will-change memory consumption is too high. Surface area covers %1$S pixels, budget is the document surface area multiplied by %2$S (%3$S pixels). Occurences of will-change over the budget will be ignored.
> +WillChangeOverBudgetIgnoredWarning=Will-change memory consumption is too high. Surface area covers %1$S pixels, budget is the document surface area multiplied by %2$S (%3$S pixels). Occurences of will-change over the budget will be ignored.

Let's take one more step in the right direction, since we're touching this string. Can you use "px" instead of "pixels"? And sorry for not noticing it immediately.

Pixel is a word, and a such it needs to be declined as a plural form. The translation for "2 pixels" might be different than "11 pixels". "px", as an abbreviation, is a lot safer.
Attachment #8637463 - Flags: review?(francesco.lodolo)
Comment on attachment 8637463 [details]
MozReview Request: Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod

Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod
Attachment #8637463 - Flags: review?(francesco.lodolo)
Yea, the cpp change is just to match the label change. Changed to 'px'.
Flags: needinfo?(bgirard)
Comment on attachment 8637463 [details]
MozReview Request: Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod

Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod
Comment on attachment 8637463 [details]
MozReview Request: Bug 1181976 - Rename WillChangeBudgetWarning in dom/dom.properties to reflect string change. r=flod

https://reviewboard.mozilla.org/r/13873/#review12527

Thanks, looks great.
Attachment #8637463 - Flags: review?(francesco.lodolo) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1fbefe335299
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1188510
No longer depends on: 1188510
You need to log in before you can comment on or make changes to this bug.