Closed Bug 1182009 Opened 4 years ago Closed 4 years ago

In the Hamburger Menu, the Sync button should have a label

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 42
Iteration:
42.3 - Aug 10
Tracking Status
firefox40 --- unaffected
firefox41 --- fixed
firefox42 --- verified

People

(Reporter: Yoric, Assigned: eoger)

References

Details

(Whiteboard: [bugday-20150805])

Attachments

(2 files)

Attached image Sync button.png
On my Nightly, the sync button doesn't have a label. That's very unclear.
Yoric, is this still a problem for you? It should be showing an "avatar" image (or more likely a generic placeholder) and your account address.
Flags: needinfo?(dteller)
I'm running the latest Nightly and I don't see any change.
Flags: needinfo?(dteller)
That's 42.0a1 (2015-07-29), btw.
Following up via IRC, David tells me Sync isn't configured and there are no errors in the console.
Bug reproduced by setting services.sync.username (= using old Sync). Working on a patch...
We'll have to uplift this I guess.
Assignee: nobody → edouard.oger
Status: NEW → ASSIGNED
Attachment #8641289 - Flags: review?(markh)
Blocks: 1139698
Comment on attachment 8641289 [details] [diff] [review]
bug-1182009.patch

Review of attachment 8641289 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!
Attachment #8641289 - Flags: review?(markh) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a64d71a817c0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Iteration: --- → 42.3 - Aug 10
Verified as fixed on:

FF 42
Build Id: 20150804030204
Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10
Comment on attachment 8641289 [details] [diff] [review]
bug-1182009.patch

Approval Request Comment
[Feature/regressing bug #]: Firefox Account information in hamburger menu
[User impact if declined]: In some cases the hamburger menu will have an empty useless area near the bottom
[Describe test coverage new/current, TreeHerder]: Trivial patch, all existing tests pass.
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8641289 - Flags: approval-mozilla-aurora?
I can verify it's fixed in Windows 7 32 bit.

User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build Id: 20150804030204
Status: RESOLVED → VERIFIED
Whiteboard: [bugday-20150805]
Comment on attachment 8641289 [details] [diff] [review]
bug-1182009.patch

Given that the fix has been verified on Nightly, it seems safe to uplift to Aurora.
Attachment #8641289 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.