Closed
Bug 1182009
Opened 9 years ago
Closed 9 years ago
In the Hamburger Menu, the Sync button should have a label
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
Tracking | Status | |
---|---|---|
firefox40 | --- | unaffected |
firefox41 | --- | fixed |
firefox42 | --- | verified |
People
(Reporter: Yoric, Assigned: eoger)
References
Details
(Whiteboard: [bugday-20150805])
Attachments
(2 files)
194.36 KB,
image/png
|
Details | |
2.14 KB,
patch
|
markh
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On my Nightly, the sync button doesn't have a label. That's very unclear.
Comment 1•9 years ago
|
||
Yoric, is this still a problem for you? It should be showing an "avatar" image (or more likely a generic placeholder) and your account address.
Flags: needinfo?(dteller)
Reporter | ||
Comment 2•9 years ago
|
||
I'm running the latest Nightly and I don't see any change.
Flags: needinfo?(dteller)
Reporter | ||
Comment 3•9 years ago
|
||
That's 42.0a1 (2015-07-29), btw.
Comment 4•9 years ago
|
||
Following up via IRC, David tells me Sync isn't configured and there are no errors in the console.
Assignee | ||
Comment 5•9 years ago
|
||
Bug reproduced by setting services.sync.username (= using old Sync). Working on a patch...
Assignee | ||
Comment 6•9 years ago
|
||
We'll have to uplift this I guess.
Comment 7•9 years ago
|
||
Comment on attachment 8641289 [details] [diff] [review] bug-1182009.patch Review of attachment 8641289 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks!
Attachment #8641289 -
Flags: review?(markh) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
status-firefox40:
--- → unaffected
status-firefox41:
--- → affected
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a64d71a817c0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•9 years ago
|
Iteration: --- → 42.3 - Aug 10
Comment 10•9 years ago
|
||
Verified as fixed on: FF 42 Build Id: 20150804030204 Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10
Comment 11•9 years ago
|
||
Comment on attachment 8641289 [details] [diff] [review] bug-1182009.patch Approval Request Comment [Feature/regressing bug #]: Firefox Account information in hamburger menu [User impact if declined]: In some cases the hamburger menu will have an empty useless area near the bottom [Describe test coverage new/current, TreeHerder]: Trivial patch, all existing tests pass. [Risks and why]: None [String/UUID change made/needed]: None
Attachment #8641289 -
Flags: approval-mozilla-aurora?
Comment 12•9 years ago
|
||
I can verify it's fixed in Windows 7 32 bit. User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 Build Id: 20150804030204
Status: RESOLVED → VERIFIED
Whiteboard: [bugday-20150805]
Comment on attachment 8641289 [details] [diff] [review] bug-1182009.patch Given that the fix has been verified on Nightly, it seems safe to uplift to Aurora.
Attachment #8641289 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•