Closed Bug 1182032 Opened 6 years ago Closed 6 years ago

Clean site icons cache regularly

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5+, b2g-master fixed)

RESOLVED FIXED
FxOS-S3 (24Jul)
blocking-b2g 2.5+
Tracking Status
b2g-master --- fixed

People

(Reporter: gmarty, Assigned: gmarty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

As discussed in Bug 1174813, site icons are currently cached forever.
We should invalidate each icon's cache on a regular basis (say every 24 hours).

Also, there is a potential privacy issue with the icon datastore, so we must also make sure to clear it completely whenever the 'Clear cookies and stored data' button of Browser Privacy settings is tapped.
Blocks: 1168944
Whiteboard: [systemsfe]
blocking-b2g: --- → 2.5+
Assignee: nobody → gmarty
Comment on attachment 8632721 [details] [review]
[gaia] gmarty:Bug-1182032-Clean-site-icons-cache-regularly > mozilla-b2g:master

Ben, can you review this patch, please?
Attachment #8632721 - Flags: review?(bfrancis)
Target Milestone: --- → FxOS-S2 (10Jul)
Target Milestone: FxOS-S2 (10Jul) → FxOS-S3 (24Jul)
Comment on attachment 8632721 [details] [review]
[gaia] gmarty:Bug-1182032-Clean-site-icons-cache-regularly > mozilla-b2g:master

Looks good to me, thanks. Sorry this took a while.

We need to do something to not delete icons for pinned sites and pages when clearing private data but I think that has to come later, let's file a follow-up.
Attachment #8632721 - Flags: review?(bfrancis) → review+
https://github.com/mozilla-b2g/gaia/commit/0455e55979a1ebcb52b4b38356668072d8fcc93c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.