1182032 - Clean site icons cache regularly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Guillaume Marty [:gmarty]]

As discussed in Bug 1174813, site icons are currently cached forever.
We should invalidate each icon's cache on a regular basis (say every 24 hours).

Also, there is a potential privacy issue with the icon datastore, so we must also make sure to clear it completely whenever the 'Clear cookies and stored data' button of Browser Privacy settings is tapped.

Comment 1

[Guillaume Marty [:gmarty]]

FYI WIP is here:
https://github.com/gmarty/gaia/tree/Bug-1182032-Clean-site-icons-cache-regularly

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1182032-Clean-site-icons-cache-regularly > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8632721 [details] [review]
[gaia] gmarty:Bug-1182032-Clean-site-icons-cache-regularly > mozilla-b2g:master

Ben, can you review this patch, please?

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8632721 [details] [review]
[gaia] gmarty:Bug-1182032-Clean-site-icons-cache-regularly > mozilla-b2g:master

Looks good to me, thanks. Sorry this took a while.

We need to do something to not delete icons for pinned sites and pages when clearing private data but I think that has to come later, let's file a follow-up.

Comment 5

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/0455e55979a1ebcb52b4b38356668072d8fcc93c