Closed Bug 1182041 Opened 9 years ago Closed 6 years ago

options variable is not undefined when failed to parse BUILD_CONFIG in gaia/build/xpcshell-commonjs.js.

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: arai, Unassigned)

References

Details

https://github.com/mozilla-b2g/gaia/blob/master/build/xpcshell-commonjs.js#L70

xpcshell has built-in "options" function, and currently SpiderMonkey's global let is not ES6 compliant and it's semantically equivalent to global var (bug 589199). so "let options;" there does nothing and "options" stays to be the built-in function.

Then, iiuc, following line expects "options" to be undefined when JSON.parse fails, but it won't be undefined.
https://github.com/mozilla-b2g/gaia/blob/master/build/xpcshell-commonjs.js#L73

it would be better to rename the "options" variable to some other name for now.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.