Closed
Bug 1182053
Opened 9 years ago
Closed 9 years ago
Upgrade to modern python-requests in tools
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
Details
Attachments
(2 files)
6.78 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
1.16 MB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Passing "config" is not supported in new versions of python-requests. It would be great if we stop using old API so we upgrade to newer and better python-requests.
Assignee | ||
Comment 1•9 years ago
|
||
If this one sticks (it passes tests), the next step will be replacing requests in the vendor directory and replacing references to it.
Attachment #8631553 -
Flags: review?(bhearsum)
Updated•9 years ago
|
Attachment #8631553 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8631553 [details] [diff] [review] raise_for_status-tools.diff https://hg.mozilla.org/build/tools/rev/1b40fea61b5b
Attachment #8631553 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Summary: Stop using danger_mode in tools → Upgrade to modern python-requests in tools
Assignee | ||
Comment 3•9 years ago
|
||
I'd like to land this on Monday.
Attachment #8631737 -
Flags: review?(bhearsum)
Comment 4•9 years ago
|
||
Comment on attachment 8631737 [details] [diff] [review] requests-tools.diff Review of attachment 8631737 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. I'm not sure it's worthwhile checking in the text files and tests, but it doesn't hurt I guess. I'll leave that up to you.
Attachment #8631737 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8631737 [details] [diff] [review] requests-tools.diff https://hg.mozilla.org/build/tools/rev/e833ebed151d
Attachment #8631737 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
FWIW, we're getting this in release-runner logs now: 2015-07-22 14:25:01,100 - DEBUG - Fetching release requests 2015-07-22 14:25:01,100 - DEBUG - Request to https://ship-it.mozilla.org/releases 2015-07-22 14:25:01,100 - DEBUG - Data sent: None 2015-07-22 14:25:01,100 - DEBUG - attempt 1/5 2015-07-22 14:25:01,100 - DEBUG - retry: Calling <function _req at 0x13c8578> with args: (), kwargs: {}, attempt #1 2015-07-22 14:25:01,101 - INFO - Resetting dropped connection: ship-it.mozilla.org /builds/releaserunner/tools/lib/python/vendor/requests-2.7.0/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning 2015-07-22 14:25:01,280 - DEBUG - "GET /releases?ready=1&complete=0 HTTP/1.1" 200 20 2015-07-22 14:25:01,281 - INFO - No new releases: {'releases': []} 2015-07-22 14:25:01,281 - DEBUG - Sleeping for 30 seconds before polling again We have Python 2.7.3, and need 2.7.9 to avoid that SSL warning (or pyopenssl).
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•