Upgrade to modern python-requests in tools

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
a month ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Passing "config" is not supported in new versions of python-requests. It would be great if we stop using old API so we upgrade to newer and better python-requests.
(Assignee)

Comment 1

3 years ago
Created attachment 8631553 [details] [diff] [review]
raise_for_status-tools.diff

If this one sticks (it passes tests), the next step will be replacing requests in the vendor directory and replacing references to it.
Attachment #8631553 - Flags: review?(bhearsum)
Attachment #8631553 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

3 years ago
Summary: Stop using danger_mode in tools → Upgrade to modern python-requests in tools
(Assignee)

Comment 3

3 years ago
Created attachment 8631737 [details] [diff] [review]
requests-tools.diff

I'd like to land this on Monday.
Attachment #8631737 - Flags: review?(bhearsum)
Comment on attachment 8631737 [details] [diff] [review]
requests-tools.diff

Review of attachment 8631737 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'm not sure it's worthwhile checking in the text files and tests, but it doesn't hurt I guess. I'll leave that up to you.
Attachment #8631737 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
FWIW, we're getting this in release-runner logs now:

2015-07-22 14:25:01,100 - DEBUG - Fetching release requests
2015-07-22 14:25:01,100 - DEBUG - Request to https://ship-it.mozilla.org/releases
2015-07-22 14:25:01,100 - DEBUG - Data sent: None
2015-07-22 14:25:01,100 - DEBUG - attempt 1/5
2015-07-22 14:25:01,100 - DEBUG - retry: Calling <function _req at 0x13c8578> with args: (), kwargs: {}, attempt #1
2015-07-22 14:25:01,101 - INFO - Resetting dropped connection: ship-it.mozilla.org
/builds/releaserunner/tools/lib/python/vendor/requests-2.7.0/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
2015-07-22 14:25:01,280 - DEBUG - "GET /releases?ready=1&complete=0 HTTP/1.1" 200 20
2015-07-22 14:25:01,281 - INFO - No new releases: {'releases': []}
2015-07-22 14:25:01,281 - DEBUG - Sleeping for 30 seconds before polling again

We have Python 2.7.3, and need 2.7.9 to avoid that SSL warning (or pyopenssl).
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.