1182091 - Test document.open() with fetch interception

Status: RESOLVED INVALID

(Core :: DOM: Service Workers, defect)

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Ehsan or Ben, may I have some feedback on the test please? I see something interesting which is the NS_NewChannel() call for document.open() is not intercepted by the service worker (that's what I see). It seems the document.open() call ends up calling NS_NewChannel() but the service worker does not intercept such request. I'd like you guys (any of you) to have a look at the test, double check and confirm what I see please. Thanks!

Comment 2

[(no longer active)]

Comment on attachment 8633382 [details] [diff] [review]
v1

Review of attachment 8633382 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is headed in the right direction, but if the channel created in document.open doesn't get intercepted, you should fix that bug first.  :-)  Please see bugs such as bug 1147695, bug 1131323, bug 1147996 and bug 1148064 for the other cases of things which we could not intercept before that I have fixed for examples.

::: dom/workers/test/serviceworkers/test_document_open_opaque_intercept.html
@@ +34,5 @@
> +  function testOpaqueIntercept() {
> +    var p = new Promise(function(resolve, reject) {
> +      var ready = false;
> +      window.onmessage = function(e) {
> +        if ((e.data.status === "callback") && (e.data.data === "ready")) {

Nit: For better readability, please switch on e.data.status, and then on e.data.data.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Ehsan, as you commented at bug 1183983 comment 2 if there is nothing to intercept here the test being added here doesn't make sense so should we resolve this one as INVALID as well? Thanks!

Comment 4

[(no longer active)]

Yes, it does.  Thanks!