Closed Bug 1182094 Opened 4 years ago Closed 4 years ago

fix sandboxed-iframes.https.html to expect rejection instead of throwing on attribute

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

Details

Attachments

(1 file)

In bug 1173467 I flipped sandboxed-iframes.https.html to expected fail because I updated our code to better reflect the spec.  Basically, the CacheStorage should be rejecting operations with SecurityError instead of throwing it directly from the .caches attribute.

This bug is to go back and fix the test to match the spec.
I previously updated our code to reject Cache operations with SecurityError instead of throwing, such as:

  https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-storage-open

This patch catches the wpt tests up with that spec change.

I also moved the pref setting to __dir__.ini and removed otherwise unneeded .ini files for the directory.
Attachment #8660846 - Flags: review?(james)
Comment on attachment 8660846 [details] [diff] [review]
Fix wpt sandboxed-iframes.https.html test to expect rejected promises. r=jgraham

Review of attachment 8660846 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/service-workers/cache-storage/resources/iframe.html
@@ +14,2 @@
>      } catch (e) {
> +        window.parent.postMessage({id: id, result: 'unexpecteddenied', name: e.name, message: e.message}, '*');

I might have called this 'exception', but OK.
Attachment #8660846 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/9abb92bb199c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.