1182094 - fix sandboxed-iframes.https.html to expect rejection instead of throwing on attribute

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 1173467 I flipped sandboxed-iframes.https.html to expected fail because I updated our code to better reflect the spec.  Basically, the CacheStorage should be rejecting operations with SecurityError instead of throwing it directly from the .caches attribute.

This bug is to go back and fix the test to match the spec.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix wpt sandboxed-iframes.https.html test to expect rejected promises. r=jgraham

I previously updated our code to reject Cache operations with SecurityError instead of throwing, such as:

  https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-storage-open

This patch catches the wpt tests up with that spec change.

I also moved the pref setting to __dir__.ini and removed otherwise unneeded .ini files for the directory.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2d6e9c48eb

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8660846 [details] [diff] [review]
Fix wpt sandboxed-iframes.https.html test to expect rejected promises. r=jgraham

Review of attachment 8660846 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/service-workers/cache-storage/resources/iframe.html
@@ +14,2 @@
>      } catch (e) {
> +        window.parent.postMessage({id: id, result: 'unexpecteddenied', name: e.name, message: e.message}, '*');

I might have called this 'exception', but OK.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9abb92bb199c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9abb92bb199c