Closed Bug 1182141 Opened 4 years ago Closed 4 years ago

Change search default for US to Yahoo

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S4 (07Aug)

People

(Reporter: pdol, Assigned: daleharvey)

Details

(Whiteboard: [systemsfe])

User Story

For US-based SIM cards, the default search provider should be set to Yahoo, using the existing single variant customization capability.

That includes the following MCC codes:
310
311
312
313
316

Attachments

(1 file)

No description provided.
Flags: needinfo?(dale)
Flags: needinfo?(bfrancis)
Ill do this since I didnt document the customisation very well
Assignee: nobody → dale
Flags: needinfo?(dale)
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S3 (24Jul)
Flags: needinfo?(bfrancis)
Hey Doug, been getting a failure building spark for the last few days now (clean checkouts etc)

https://gist.github.com/daleharvey/c5415dd96f493c6a3f3d

Anything known broken?
Flags: needinfo?(drs)
Strange. I've seen this before, but I've never had it happen to me. I don't know how to fix it.

Note that this setting should not be dependent on Spark. It should be part of "base" FxOS.
Flags: needinfo?(drs)
Attachment #8643087 - Flags: review?(bfrancis)
Dale's patch changes the default search engine to DuckDuckGo, except for the US where it is Yahoo. This would be the default for all distributions (not just the Foxfooding builds) unless overridden by a customisation. Peter, is that OK?
Flags: needinfo?(pdolanjski)
Comment on attachment 8643087 [details] [review]
[gaia] daleharvey:1182141 > mozilla-b2g:master

Sorry Dale, Peter asked the search team and they said that the global default outside of the US should be Google. If you make that change we can get this landed.
Flags: needinfo?(pdolanjski)
Attachment #8643087 - Flags: review?(bfrancis)
Comment on attachment 8643087 [details] [review]
[gaia] daleharvey:1182141 > mozilla-b2g:master

Switched to only to the yahoo for us sims change
Attachment #8643087 - Flags: review?(bfrancis)
Comment on attachment 8643087 [details] [review]
[gaia] daleharvey:1182141 > mozilla-b2g:master

Thanks
Attachment #8643087 - Flags: review?(bfrancis) → review+
This already has a green test run, so landing, cheers

https://github.com/mozilla-b2g/gaia/commit/6af83bf581235920c7f769c40e3c1cfcbe329b7b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.