1182164 - Show which tab is playing sound from Flash

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

+++ This bug was initially created as a clone of Bug #1018504 +++

We need to do some work to allow Flash content in the tab to be muted. Because of the way Flash works, this is possible, but we need to hook up to whatever API there is for the frontend.

Comment 1

[(no longer active)]

Flash on Android is not getting updated, right?  The Flash API that we need for this is very new, which was just implemented in the latest version of Flash, so unless if there is a hope in Adobe shipping another Flash for Android, I don't think there is anything we can do for Flash content on mobile.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Flash works differently on Android. We actually expose the interface that allows Flash to play sounds there [0], so we should be able to hook this up.

[0] https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/android/ANPAudio.cpp

Comment 3

[(no longer active)]

Hmm, based on a very quick skimming of that code, it doesn't seem like you can control which plugin instance is playing audio to be able to do per-tab mute like we can do on desktop...  Is that OK?

Comment 4

[(no longer active)]

In order to make it easier to track what blocks bug 486262, I am removing the dependency on this bug.  All of the Gecko and toolkit related changed have landed, and bug 486262 is specific to Firefox Desktop.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Updated summary since bug 1018504 is the general audio case.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

I thought this depends on recent versions of Flash? Version 18.x is not available on Android.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to :Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #3)
> Hmm, based on a very quick skimming of that code, it doesn't seem like you
> can control which plugin instance is playing audio to be able to do per-tab
> mute like we can do on desktop...  Is that OK?

Ugh, it looks like you are right. I thought we had some context that would allow us to map to a nsNPAPIPluginInstance like we do in other places, but I don't see it. Not sure what we should do now.

Comment 8

[(no longer active)]

Hmm, I don't know how popular Flash on Android is.  For the desktop case, we got go ahead from the UX team go ignore Flash audio completely before Adobe implemented the new APIs.  So if that is any indication, we can just not deal with Flash on Android.

Comment 9

[Jan Henning [:JanH]]

Flash is going away (bug 1381916), so there's no point in pursuing this further.