1182195 - [Contacts] Unable to import contacts from email [Gmail/Outlook]; account sign in then import activity closes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Oliver Nelson [:oliverthor]]

Description:
When the user attempts to import contacts from an e-mail account (Gmail or Outlook), they will observe that after signing into their email that the 'import activity' will seem to disappear without performing another. The contacts UI for these emails will show 'Not imported'. Attempting to import again will try to check the email account (grant access to gmail | bring a screen up from bottom from outlook), which will be dismissed quickly afterwards.
Note that importing contacts from email IS SUCCESSFUL when performed in the FTU; only in the contacts app does it fail. These results match across all branch checks.

PreReq:
* gmail or outlook account with contacts to import
Repro Steps:
1) Update phone to 20150709010204
2) Open the contacts app
3) Tap 'gear' for settings
4) Import contacts from gmail/outlook
5) Sign into email account; progress through import flow
6) After 'import' observe settings screen

Actual:
No contacts were imported from email account; activity dismisses

Expected:
Contacts are imported


Environment Variables:
--------------------------

Environmental Variables:
Device: Aries 2.5
Build ID: 20150709163506
Gaia: fc6643dd3da2ccdf2ab284479643836bb3698644
Gecko: d656ef3c4936
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Flame 2.5
Build ID: 20150709010204
Gaia: fc6643dd3da2ccdf2ab284479643836bb3698644
Gecko: f34a7120f46b
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
***********************

Issue DOES NOT REPRO on 2.2 for flame devices
Results: Contacts are imported

Device: Flame 2.2
BuildID: 20150709002503
Gaia: d6d6a35b9407ffaf3131bc244cabc8ee2b09c4df
Gecko: e0f4a13fd1f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------

Repro frequency: 5/5
See attached: 
video- https://youtu.be/cL8w6hql6Pc
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression

Requesting a window.

Comment 2

[Maria Angeles Oteo (:oteo)]

It seems to be a regression introduced in Bug 1175815. We will have a look tomorrow, thanks!

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150708034822
Gaia: 80ebbe3f3d72dcd00d52139d32e567a894613ed6
Gecko: 0ac69020c0c0
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame
BuildID: 20150708043821
Gaia: fc6643dd3da2ccdf2ab284479643836bb3698644
Gecko: 90d8db1e9c9e
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 80ebbe3f3d72dcd00d52139d32e567a894613ed6
Gecko: 90d8db1e9c9e

Last Working Gecko First Broken Gaia - repro
Gaia: fc6643dd3da2ccdf2ab284479643836bb3698644
Gecko: 0ac69020c0c0

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/80ebbe3f3d72dcd00d52139d32e567a894613ed6...fc6643dd3da2ccdf2ab284479643836bb3698644

Confirmed comment 2's suspicion that this is caused by changes made in Bug 1175815.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Jorge, can you take a look at this please? Looks like this was caused by the landing for bug 1175815.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mancas:bug1182195 > mozilla-b2g:master

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8632046 [details] [review]
[gaia] mancas:bug1182195 > mozilla-b2g:master

Hey Borja! Can you review this patch?

Thanks!

Comment 7

[Maria Angeles Oteo (:oteo)]

This bug was tested with flame master (7/13) version and verified that the importing was done successfully.

Environmental variables:
flame master (2.5.0 version)
Build ID: 20150713
Gecko: 9d932ee
Gaia: 167a22b
Platform version: 42.0a1

Today a new bug has been raised (see bug 1183301) but it's completely different from this one, as it seems to be a gecko regression and not part of the NGA work.

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Contacts are imported from Gmail/Outlook successfully no matter how many times.
See attachment: verify_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150909150223
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150909.185733
Firmware Date          Wed Sep  9 18:57:43 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150909215153
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150909.211310
Firmware Date          Wed Sep  9 21:13:17 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: Verify_Aries_v2.5.3gp