1182263 - Include Firefox Account oauth endpoint in AndroidFxAccount

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Firefox Accounts, defect, P3)

Description

[Vivek Balakrishnan[:vivek]]

This is a larger ticket for the following changes:

* The current static factory in AndroidFxAccount is really bloated. Refactor that with configuration holder object. Refer [1] for an example

* Add OAuth server Url to AndroidFxAccount

[1] https://github.com/mozilla-services/android-sync/commit/7d16d2672dc180979f50ca92a5f41f94f9ab7dde#diff-0b983f405fc6414bc0c47431c2965a4eR14

Comment 1

[Vivek Balakrishnan[:vivek]]

Attachment: MozReview Request: Bug 1182263 - Firefox Account server configuration related refactoring r?nalexander.

Bug 1182263 - Firefox Account server configuration related refactoring  r?nalexander.

* Added ServerConfiguration holder object for various FxAccount related URIs.
* Refactored AndroidFxAccount creation, pickling, unpickling logic.
* Pickling logic writes serverconfiguration type and server endpoint if needed.
* UnPickling logic uses fallback to read existing configuration without bumping the version number.

Following cases where tested:
* New Login
* After login check pickled file to verify config_type is set
* Copy a backup of new version fxa.account.json file after deleting account. Check unpickling.
* Copy a backup old fxa.account.json file, delete account. Should use fallback logic and config_type should be set
* Create new account using Fxa-Custom-server addon.

Comment 2

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8633563 [details]
MozReview Request: Bug 1182263 - Firefox Account server configuration related refactoring  r?nalexander.

Bug 1182263 - Firefox Account server configuration related refactoring  r?nalexander.

* Added ServerConfiguration holder object for various FxAccount related URIs.
* Refactored AndroidFxAccount creation, pickling, unpickling logic.
* Pickling logic writes serverconfiguration type and server endpoint if needed.
* UnPickling logic uses fallback to read existing configuration without bumping the version number.

Following cases where tested:
* New Login
* After login check pickled file to verify config_type is set
* Copy a backup of new version fxa.account.json file after deleting account. Check unpickling.
* Copy a backup old fxa.account.json file, delete account. Should use fallback logic and config_type should be set
* Create new account using Fxa-Custom-server addon.

Comment 3

[Vivek Balakrishnan[:vivek]]

Attachment: MozReview Request: Bug 1182263 - Fixed profile image missing in debug mode r?nalexander.

Bug 1182263 - Fixed profile image missing in debug mode r?nalexander.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8633620 [details]
MozReview Request: Bug 1182263 - Fixed profile image missing in debug mode r?nalexander.

https://reviewboard.mozilla.org/r/13225/#review13225

::: mobile/android/base/fxa/activities/FxAccountStatusFragment.java:506
(Diff revision 1)
> +      // profilePreference is set during addPreferences, so it's definitely not null here.

This comment seems wrong or not necessary.

::: mobile/android/base/fxa/authenticator/AndroidFxAccount.java:808
(Diff revision 1)
> -          LocalBroadcastManager.getInstance(context).sendBroadcast(makeDeletedAccountIntent());
> +          LocalBroadcastManager.getInstance(context).sendBroadcast(makeProfileJSONUpdatedIntent());

Aha!  I wonder if this is causing Edwin's avatar missing thing?

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8633563 [details]
MozReview Request: Bug 1182263 - Firefox Account server configuration related refactoring  r?nalexander.

Now that Sign in to FxA on the Web is riding the Fennec trains, we should reconsider this, but I don't have time to do so now.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Bulk edit: moving potentially relevant issues from disabled Android Background Services product to Firefox for Android.

Removing priority to throw back to triage owners: please close these bugs if they're no longer relevant! Thanks!

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.