Closed Bug 1182272 Opened 10 years ago Closed 10 years ago

Make WebChannel registration in fxa-web-signin-addon more consistent

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

We should separate "endpoint configuration" from "sign in to sync". Right now I register and unregister the WebChannel listener a little too dynamically: the sign in to sync action asks for the endpoint, and then registers and unregisters around the flow. We should leave the WebChannel listener registered always, only updating when the pref changes.
This might not be perfect, but I'm going to close this out since I've pushed some improvements: https://github.com/ncalexan/fxa-web-signin-addon/commit/a9d0b2137031b6028347756e38f0707c2c26fc25
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → nalexander
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.