1182273 - Support different protocols and manifests in determining application launch origins

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

Right now the appLaunch performance marker assumes that all apps will be launched via app:// and only uses manifest.webapp, but that isn't the case. We should try to make this as generic as possible so we can see the launch time of *any* app.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] eliperelman:bug-1182273 > mozilla-b2g:master

Comment 2

[:Eli Perelman]

Comment on attachment 8631801 [details] [review]
[gaia] eliperelman:bug-1182273 > mozilla-b2g:master

Chris+Fabrice, do you see any problems going with this approach? Ultimately what I am looking for it to capture the origin of the application we are going to launch, and I'd like it to be done in a manner that will work in the future. Thoughts?

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8631801 [details] [review]
[gaia] eliperelman:bug-1182273 > mozilla-b2g:master

I don't see anything wrong with this - r+ from a code perspective, but I think Fabrice will know a lot better than me if this makes general sense.

Comment 4

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/gaia/commit/4ff6ec7ea4ccf76f891bc5cb7b28d0376c852535

Fabrice, if you have any concerns, feel free to follow up and I'll make the changes.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8631801 [details] [review]
[gaia] eliperelman:bug-1182273 > mozilla-b2g:master

We support multiple apps per origin, so your solution will not disambiguate this case.
The unique id for apps is the manifest url.